Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undici crash even when fetch is not used #1263

Closed
syamsudotdev opened this issue Mar 26, 2024 · 1 comment · Fixed by #1264
Closed

Undici crash even when fetch is not used #1263

syamsudotdev opened this issue Mar 26, 2024 · 1 comment · Fixed by #1264
Assignees

Comments

@syamsudotdev
Copy link
Contributor

Describe the bug
Running Monika with --symonUrl <URL> --symonKey <UUID> --follow-redirects=5 --retryInitialDelayMs=150000 --ignoreInvalidTLS will log errors from undici.

To Reproduce
Steps to reproduce the behavior:

  1. monika --symonUrl <URL> --symonKey <UUID> --follow-redirects=5 --retryInitialDelayMs=150000 --ignoreInvalidTLS
  2. See error in screenshot

Expected behavior
Running command mentioned above should not log undici errors, as Monika is not provided with --native-fetch flag. Thus not using node.js' fetch API and should not log undici errors.

Screenshots
image

Desktop (please complete the following information):

  • OS: [e.g. Ubuntu]
  • Version [e.g. 18.04]

Additional context
Add any other context about the problem here.

@syamsudotdev syamsudotdev self-assigned this Mar 26, 2024
@dennypradipta
Copy link
Contributor

Got this thought after waking up today: Maybe Monika v1.19.1 isn't running very well with Symon because Monika didn't catch this error, hence breaking the probing mechanism, causing Monika only reported few probes only.

@syamsudotdev syamsudotdev changed the title Undici logs errors even when fetch is not used Crash even when fetch is not used Mar 28, 2024
@syamsudotdev syamsudotdev changed the title Crash even when fetch is not used Undici crash even when fetch is not used Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants