From f5ede41523c60d6bfbea3f4f64e2ea84449d2565 Mon Sep 17 00:00:00 2001 From: urvish667 Date: Mon, 18 Sep 2023 12:39:56 +0530 Subject: [PATCH] build(tools/docker/indy-sdk-cli): fix deprecation deb.nodesource.com/setup_16.x **Primary Change:** In the Dockerfile, the issue related to NodeJS was addressed by updating the NodeJS installation method to use the new NodeSource installation method. The previous method using `curl -sL https://deb.nodesource.com/setup_16.x | bash -` had become deprecated, so the new method was applied for compatibility with the latest practices. The specific changes made in the Dockerfile are as follows: 1. Removed the old installation method for NodeJS: ```Dockerfile # Removed the deprecated NodeJS installation method # RUN curl -sL https://deb.nodesource.com/setup_16.x | bash - ``` 2. Added the new NodeSource installation method: ```Dockerfile RUN curl -fsSL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | \ gpg --dearmor -o /usr/share/keyrings/nodesource-archive-keyring.gpg \ && echo "deb [arch=amd64 signed-by=/usr/share/keyrings/nodesource-archive-keyring.gpg] \ https://deb.nodesource.com/node bionic main" | \ tee /etc/apt/sources.list.d/nodesource.list ``` [skip ci] Co-authored-by: Peter Somogyvari Signed-off-by: urvish667 Signed-off-by: Peter Somogyvari --- tools/docker/indy-sdk-cli/Dockerfile | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/docker/indy-sdk-cli/Dockerfile b/tools/docker/indy-sdk-cli/Dockerfile index 1e03203b52..4c81c38a21 100644 --- a/tools/docker/indy-sdk-cli/Dockerfile +++ b/tools/docker/indy-sdk-cli/Dockerfile @@ -22,8 +22,9 @@ RUN apt-get update \ make \ && rm -rf /var/lib/apt/lists/* -# NodeJS -RUN curl -sL https://deb.nodesource.com/setup_16.x | bash - +# NodeJS - Updated to use the new NodeSource installation method +RUN curl -fsSL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | gpg --dearmor -o /usr/share/keyrings/nodesource-archive-keyring.gpg \ + && echo "deb [arch=amd64 signed-by=/usr/share/keyrings/nodesource-archive-keyring.gpg] https://deb.nodesource.com/node bionic main" | tee /etc/apt/sources.list.d/nodesource.list # Indy-sdk RUN apt-key adv --keyserver keyserver.ubuntu.com --recv-keys CE7709D068DB5E88 \