Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cactus-example-tcs-huawei): use openapi ethereum connector #2820

Closed
outSH opened this issue Oct 20, 2023 · 6 comments
Closed

feat(cactus-example-tcs-huawei): use openapi ethereum connector #2820

outSH opened this issue Oct 20, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@outSH
Copy link
Contributor

outSH commented Oct 20, 2023

Is your feature request related to a problem? Please describe.
We are phasing out legacy cactus-plugin-ledger-connector-go-ethereum-socketio which is used by cactus-example-tcs-huawei sample app. This old connector must be replaced with new, openapi based one - cactus-plugin-ledger-connector-ethereum.

Describe the solution you'd like
Refactor sample app to use cactus-plugin-ledger-connector-ethereum (similar work to this PR - #2735).

@123wyl123 please investigate and let me know if you can do it :)

@outSH outSH added the enhancement New feature or request label Oct 20, 2023
@outSH
Copy link
Contributor Author

outSH commented Nov 27, 2023

@123wyl123 any updates regarding updating of tcs sample app?

@123wyl123
Copy link

@outSH Sorry for replying to your message now.
I will revise the implementation of that part and submit it as soon as possible

@outSH
Copy link
Contributor Author

outSH commented Jan 19, 2024

@123wyl123 I'm happy to hear that! If you encounter any trouble please reach out to me :)

Another thing which would be nice to do before our V2 release is to upgrade cactus-plugin-ledger-connector-tcs-huawei-socketio you've contributed to openapi-based connector. Example of simple openapi connector to get the idea is here - #2962

Please let me know if you can do that as well

@petermetz
Copy link
Contributor

@123wyl123 Plus one to what @outSH said above! I'm happy to help as well!

@outSH
Copy link
Contributor Author

outSH commented Mar 11, 2024

@123wyl123 Hello, do you have any questions or problems regarding this? Please note that I've also opened a separate issue for open-api migration that I've mentioned in a previous comment (which is also important since it blocks removal of socketio-server) - #3076

@petermetz
Copy link
Contributor

Closing this for now because we've phased out the components in question.

@petermetz petermetz closed this as not planned Won't fix, can't repro, duplicate, stale Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants