-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(github): commit parity check for PRs should show what is wrong #3470
Comments
I am working on this |
@petermetz I will make the checks looser while keeping the check relevant (It would be very irritating working on a task, creating a PR and then getting stuck comparing and fixing the PR and the related commit.) |
@jagpreetsinghsasan Thank you for the work on the improvements in advance! I thought about it a little more and would strongly recommend to refactor it to be less strict by only demanding a certain level of string similarity, otherwise it will probably just end up being super annoying 90% of the time for contributors in the cases when they just have some silly typo making a difference. I found this library that looks very versatile and perfect for the task: Specifically I would recommend the custom check to have a 90% ( The other thing: It would be very handy to be able to configure the threshold from an env variable so that later on if we find that a higher or lower threshold is better, we don't have to touch the code at all just set the env var in ci.yaml or somewhere else where the job is defined (technically still a code-change I know, but it's in the yaml not in the actual logic) |
Oh wow. This looks like a perfect solution to do a looser string matching. I will incorporate the same with a variable input of similarity ratio. Thanks @petermetz for the insights |
@jagpreetsinghsasan You got it! Thank you as well! |
Primary Changes --------------- 1. Added a commit-pr similarity ratio to lessen the check strictness 2. Added an env var to the workflow to easily control the similarity ratio Changes required to incorporate 1) --------------------------------- 3. Added string-similarity-js package in package.json Fixes hyperledger-cacti#3470 Signed-off-by: jagpreetsinghsasan <[email protected]>
Primary Changes --------------- 1. Added a commit-pr similarity ratio to lessen the check strictness 2. Added an env var to the workflow to easily control the similarity ratio Changes required to incorporate 1) --------------------------------- 3. Added string-similarity-js package in package.json Fixes hyperledger-cacti#3470 Signed-off-by: jagpreetsinghsasan <[email protected]>
Primary Changes --------------- 1. Added a commit-pr similarity ratio to lessen the check strictness 2. Added an env var to the workflow to easily control the similarity ratio Changes required to incorporate 1) --------------------------------- 3. Added string-similarity-js package in package.json Fixes hyperledger-cacti#3470 Signed-off-by: jagpreetsinghsasan <[email protected]>
Primary Changes --------------- 1. Added a commit-pr similarity ratio to lessen the check strictness 2. Added an env var to the workflow to easily control the similarity ratio Changes required to incorporate 1) --------------------------------- 3. Added string-similarity-js package in package.json Fixes hyperledger-cacti#3470 Signed-off-by: jagpreetsinghsasan <[email protected]>
Primary Changes --------------- 1. Added a commit-pr similarity ratio to lessen the check strictness 2. Added an env var to the workflow to easily control the similarity ratio Changes required to incorporate 1) --------------------------------- 3. Added string-similarity-js package in package.json Fixes hyperledger-cacti#3470 Signed-off-by: jagpreetsinghsasan <[email protected]>
Primary Changes --------------- 1. Added a commit-pr similarity ratio to lessen the check strictness 2. Added an env var to the workflow to easily control the similarity ratio Changes required to incorporate 1) --------------------------------- 3. Added string-similarity-js package in package.json Fixes hyperledger-cacti#3470 Signed-off-by: jagpreetsinghsasan <[email protected]>
Primary Changes --------------- 1. Added a commit-pr similarity ratio to lessen the check strictness 2. Added an env var to the workflow to easily control the similarity ratio Changes required to incorporate 1) --------------------------------- 3. Added string-similarity-js package in package.json Fixes hyperledger-cacti#3470 Signed-off-by: jagpreetsinghsasan <[email protected]>
Description
I dogfooded the PR commit message parity check and could not figure out what the problem was (e.g. what was different in my PR description vs my commit message).
The pull request where the check is failing despite my best effort to sync up the description and the commit message:
https://github.com/hyperledger/cacti/pull/3456
Acceptance Criteria
The text was updated successfully, but these errors were encountered: