Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(custom-checks): add check to ensure all packages are public scoped #3666

Open
petermetz opened this issue Dec 2, 2024 · 0 comments
Open

ci(custom-checks): add check to ensure all packages are public scoped #3666

petermetz opened this issue Dec 2, 2024 · 0 comments
Assignees
@petermetz
Labels
Flaky-Test-Automation Issues related to test stability (which is a long running issue that can never fully be solved) P2 Priority 2: High Tests Anything related to tests be that automatic or manual, integration or unit, etc.
Milestone
v2.2.0

Comments

@petermetz
Copy link
Contributor

Description

If any of the packages are scoped private (which breaks the release automation) then this should be caught immediately at the time when the pull request is being submitted that is adding a package as private or making an existing package private.

If we have private packages then the publishing fails with errors logs (will open a separate issue to fix those):

2024-12-02T17-20-58-nodejs-package-publish-crash-private-pkg-vs-provenance.log

Acceptance Criteria

  1. It is not possible to pass the custom-checks if any of the packages are not set to public access explicitly in the package.json
@petermetz petermetz added Flaky-Test-Automation Issues related to test stability (which is a long running issue that can never fully be solved) Tests Anything related to tests be that automatic or manual, integration or unit, etc. P2 Priority 2: High labels Dec 2, 2024
@petermetz petermetz added this to the v2.2.0 milestone Dec 2, 2024
@petermetz petermetz self-assigned this Dec 2, 2024
@outSH outSH mentioned this issue Dec 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
Flaky-Test-Automation Issues related to test stability (which is a long running issue that can never fully be solved) P2 Priority 2: High Tests Anything related to tests be that automatic or manual, integration or unit, etc.
Projects
None yet
Milestone
v2.2.0
Development

No branches or pull requests
1 participant
@petermetz