fix(dast): ccp, sshconfig missing #3676
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raynatopedrajeta
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna,
sandeepnRES and
outSH
as code owners
raynatopedrajeta
changed the title
raynatopedrajeta
force-pushed
the
raynatopedrajeta/issue3671
branch
from
ba270e1 to
4da6f88
Compare
raynatopedrajeta
changed the title
raynatopedrajeta
force-pushed
the
raynatopedrajeta/issue3671
branch
3 times, most recently
from
5f7ff7a to
75f266e
Compare
Primary Changes ---------------- 1. Fix the issue on plugin-ledger-connector-fabric that throws an error when there is no sshConfig available. Fixes hyperledger-cacti#3671 Signed-off-by: raynato.c.pedrajeta <[email protected]>
raynatopedrajeta
force-pushed
the
raynatopedrajeta/issue3671
branch
from
75f266e to
67e846e
Compare
|
Hello @petermetz , FYI, run has proceeded. However, I am getting this timeout issue upon multiple tries: Thank you! Rayn |
|
@raynatopedrajeta basically we have to update the code in a way, the fabric plugin import in DAST scan doesn't change (very much fixable in my opinion). Please have a look again into this when you are back from leave. Closing the PR as this PR doesn't provide the correct solution and also breaks the DAST scan completely |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit to be reviewed
fix(dast) :ccp, sshconfig missing
Fixes #3671
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.