Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(corda): com.github.bft-smart:library:master-v1.1-beta-g6215ec8-87 not found #3722

Closed
jagpreetsinghsasan opened this issue Jan 15, 2025 · 0 comments · Fixed by #3738
Closed
Assignees
Labels
bug Something isn't working Corda Tests Anything related to tests be that automatic or manual, integration or unit, etc.

Comments

@jagpreetsinghsasan
Copy link
Contributor

Describe the bug

Currently the cpl-connector-corda fails with the following logs
cpl-connector-corda.log

To Reproduce

Run the CI with some changes in the corda package or any related package, so that the tests for cpl-connector-corda gets triggered. The tests will then fail when the CI is executed.

Expected behavior

The above mentioned tests shouldn't fail.

Logs/Stack traces

Logs are linked above

Hyperledger Cactus Plugins/Connectors Used

  • Corda

Additional context

The above mentioned CI tests aren't failing locally as tested by @adrianbatuto , but only failing on our CI

@jagpreetsinghsasan jagpreetsinghsasan added bug Something isn't working Corda Tests Anything related to tests be that automatic or manual, integration or unit, etc. labels Jan 15, 2025
@petermetz petermetz assigned petermetz and unassigned adrianbatuto Feb 4, 2025
@petermetz petermetz changed the title bug(ci): cpl-connector-corda fails fix(corda): com.github.bft-smart:library:master-v1.1-beta-g6215ec8-87 not found Feb 4, 2025
petermetz added a commit to petermetz/cacti that referenced this issue Feb 4, 2025
… not found

Primary Changes:
-----------------

0. Spring Boot had to be updated from v3.3.1 to v3.4.2. This then set off a chain
reaction of a several other cascading problems but once all of them got rolled updated
the build and the test itself started passing again.
1. I had to remove the logic in Application.kt which was overriding the
poolSize of the ThreadPoolTaskScheduler's because it wouldn't compile with
newer versions of Spring Boot. It was complaining about missing methods at
runtime (it was trying to call the methods through reflection)
2. The gradle version for both the ADVANCED_NEGOTIATION and ADVANCED_OBLIGATION
sample cordapps had to be fixed to 7.6.3 instead of the looser 7.6 because this
was causing build issues with the cordapps within the AIO container.
This is accomplished by `sed` during the AIO container image's build.
3. The transitive dependency "com.github.bft-smart" library's version had to be
overridden within the gradle build of both cordapp sample apps ADVANCED_NEGOTIATION and
ADVANCED_OBLIGATION because the version that the corda was pinning to earlier disappeared
from the internet (specifically from JitPack).
4. The kotlin version had to be bumped from v1.9.x to v2.1.0 in the gradle builds across
the board.

The test case in
  packages/cactus-plugin-ledger-connector-corda/src/test/typescript/
  integration/corda-v4-deploy-and-invoke-contract.test.ts
is now passing as seen below:

```sh
$ yarn test:jest:all 'packages/cactus-plugin-ledger-connector-corda/src/test/
typescript/integration/corda-v4-deploy-and-invoke-contract.test.ts'

PASS packages/cactus-plugin-ledger-connector-corda/src/test/typescript/
integration/corda-v4-deploy-and-invoke-contract.test.ts (201.97 s, 139 MB heap size)
  Corda V4 Connector
    ✓ Runs listFlowsV1() (36 ms)
    ✓ Runs diagnoseNodeV1() (84 ms)
    ✓ Runs deployContractJarsV1() - ADVANCED_NEGOTIATION (59004 ms)
    ✓ Validates Requests: - deployContractJarsV1 - not sending all required parameters (73 ms)
    ✓ Validates Requests: - diagnoseNodeV1 - sending invalid parameters (14 ms)
    ✓ Validates Requests: - invokeContractV1 - not sending all required parameters (87 ms)
    ✓ Validates Requests: - deployContractJarsV1 - sending invalid parameters - rpcCredentials
    ✓ Validates Requests: - deployContractJarsV1 - sending invalid parameters - sshCredentials
    ✓ Validates Requests: - listFlowsV1 - sending invalid parameters (12 ms)
    ✓ Validates Requests: - invokeContractV1 - sending invalid parameters (23 ms)
    ✓ Runs invokeContractV1() - net.corda.samples.negotiation.flows.ProposalFlow$Initiator
    ✓ Runs deployContractJarsV1() - ADVANCED_OBLIGATION (84192 ms)
    ✓ Runs invokeContractV1() - net.corda.samples.obligation.flows.IOUIssueFlow (6009 ms)

Test Suites: 1 passed, 1 total
Tests:       13 passed, 13 total
Snapshots:   0 total
Time:        202 s, estimated 435 s
Ran all test suites matching /packages\/cactus-plugin-ledger-connector-corda\/src\/test\
/typescript\/integration\/corda-v4-deploy-and-invoke-contract.test.ts/i.
```

Fixes hyperledger-cacti#3722

Signed-off-by: Peter Somogyvari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Corda Tests Anything related to tests be that automatic or manual, integration or unit, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants