Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[suggestion] Stop encoding X25519 keys as Ed25519 #4174

Closed
Arjentix opened this issue Dec 25, 2023 · 2 comments
Closed

[suggestion] Stop encoding X25519 keys as Ed25519 #4174

Arjentix opened this issue Dec 25, 2023 · 2 comments
Assignees
@Arjentix @timofeevmd
Labels
crypto iroha2-dev The re-implementation of a BFT hyperledger in RUST QA-confirmed This bug is reproduced and needs a fix Refactor Improvement to overall code quality Security This issue asks for improved security

Comments

@Arjentix
Copy link
Contributor

While looks like it works fine I suggest refactoring that part to make it more clear.

Currently two completely different types are casted between each other in completely implicit and silent way. I suggest to make it clear that X25519 is used only for exchanging purposes.
@Arjentix Arjentix added iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality Security This issue asks for improved security labels Dec 25, 2023
@Arjentix Arjentix mentioned this issue Dec 28, 2023
Merged
5 tasks
@DCNick3 DCNick3 added the crypto label Jan 10, 2024
@mversic
Copy link
Contributor

mversic commented Jan 11, 2024

also consider this comment when handling this issue

Arjentix added a commit to Arjentix/iroha that referenced this issue Feb 12, 2024
@Arjentix
[refactor] hyperledger-iroha#4174: Stop encoding X25519 keys as Ed25519
f6ce1b7 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix Arjentix mentioned this issue Feb 12, 2024
Merged
5 tasks
Arjentix added a commit to Arjentix/iroha that referenced this issue Feb 13, 2024
@Arjentix
[refactor] hyperledger-iroha#4174: Stop encoding X25519 keys as Ed25519
ee6d385 
Signed-off-by: Daniil Polyakov <[email protected]>
Arjentix added a commit to Arjentix/iroha that referenced this issue Feb 13, 2024
@Arjentix
[refactor] hyperledger-iroha#4174: Stop encoding X25519 keys as Ed25519
eddb38a 
Signed-off-by: Daniil Polyakov <[email protected]>
Arjentix added a commit to Arjentix/iroha that referenced this issue Feb 14, 2024
@Arjentix
[refactor] hyperledger-iroha#4174: Stop encoding X25519 keys as Ed25519
631322a 
Signed-off-by: Daniil Polyakov <[email protected]>
Arjentix added a commit that referenced this issue Feb 14, 2024
@Arjentix
[refactor] #4174: Stop encoding X25519 keys as Ed25519
960f657 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Copy link
Contributor Author

Regarding testing I suggest just to check that network works as expected

@timofeevmd timofeevmd self-assigned this Feb 19, 2024
@timofeevmd timofeevmd added the QA-confirmed This bug is reproduced and needs a fix label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arjentix Arjentix

@timofeevmd timofeevmd

Labels
crypto iroha2-dev The re-implementation of a BFT hyperledger in RUST QA-confirmed This bug is reproduced and needs a fix Refactor Improvement to overall code quality Security This issue asks for improved security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@DCNick3 @Arjentix @mversic @timofeevmd