fix to call _msgSender() once

Signed-off-by: Jun Kimura <[email protected]>

Author: bluele

.gas-snapshot

@@ -1,20 +1,20 @@
 IBCMockAppTest:testHandshake() (gas: 4420356)
 IBCMockAppTest:testHandshakeBetweenDifferentPorts() (gas: 3334286)
-IBCMockAppTest:testPacketRelay() (gas: 13931833)
-IBCMockAppTest:testPacketTimeout() (gas: 4279248)
+IBCMockAppTest:testPacketRelay() (gas: 13932025)
+IBCMockAppTest:testPacketTimeout() (gas: 4279264)
 IBCTest:testBenchmarkCreateMockClient() (gas: 233366)
 IBCTest:testBenchmarkLCUpdateMockClient() (gas: 62005)
 IBCTest:testBenchmarkRecvPacket() (gas: 158921)
-IBCTest:testBenchmarkSendPacket() (gas: 128424)
+IBCTest:testBenchmarkSendPacket() (gas: 128432)
 IBCTest:testBenchmarkUpdateMockClient() (gas: 160229)
 IBCTest:testToUint128((uint64,uint64)) (runs: 256, μ: 947, ~: 947)
-TestICS02:testCreateClient() (gas: 36495526)
-TestICS02:testInvalidCreateClient() (gas: 36392801)
-TestICS02:testInvalidUpdateClient() (gas: 36391653)
-TestICS02:testRegisterClient() (gas: 36047252)
-TestICS02:testRegisterClientDuplicatedClientType() (gas: 36032561)
-TestICS02:testRegisterClientInvalidClientType() (gas: 36061888)
-TestICS02:testUpdateClient() (gas: 36559853)
+TestICS02:testCreateClient() (gas: 36491844)
+TestICS02:testInvalidCreateClient() (gas: 36389119)
+TestICS02:testInvalidUpdateClient() (gas: 36387971)
+TestICS02:testRegisterClient() (gas: 36043570)
+TestICS02:testRegisterClientDuplicatedClientType() (gas: 36028879)
+TestICS02:testRegisterClientInvalidClientType() (gas: 36058206)
+TestICS02:testUpdateClient() (gas: 36556171)
 TestICS03Handshake:testConnOpenAck() (gas: 1858296)
 TestICS03Handshake:testConnOpenConfirm() (gas: 2054231)
 TestICS03Handshake:testConnOpenInit() (gas: 1429882)
@@ -40,29 +40,29 @@ TestICS04Handshake:testInvalidChanOpenConfirm() (gas: 2517409)
 TestICS04Handshake:testInvalidChanOpenInit() (gas: 1758661)
 TestICS04Handshake:testInvalidChanOpenTry() (gas: 1773244)
 TestICS04Packet:testAcknowledgementPacket() (gas: 3351462)
-TestICS04Packet:testInvalidSendPacket() (gas: 3551771)
-TestICS04Packet:testRecvPacket() (gas: 10996557)
-TestICS04Packet:testRecvPacketTimeoutHeight() (gas: 3260153)
-TestICS04Packet:testRecvPacketTimeoutTimestamp() (gas: 3279303)
-TestICS04Packet:testSendPacket() (gas: 6413328)
-TestICS04Packet:testTimeoutOnClose() (gas: 3553803)
+TestICS04Packet:testInvalidSendPacket() (gas: 3551893)
+TestICS04Packet:testRecvPacket() (gas: 10996621)
+TestICS04Packet:testRecvPacketTimeoutHeight() (gas: 3260169)
+TestICS04Packet:testRecvPacketTimeoutTimestamp() (gas: 3279319)
+TestICS04Packet:testSendPacket() (gas: 6413456)
+TestICS04Packet:testTimeoutOnClose() (gas: 3553819)
 TestICS04Upgrade:testUpgradeAuthorityCancel() (gas: 46740549)
 TestICS04Upgrade:testUpgradeCannotCancelWithOldErrorReceipt() (gas: 3455585)
-TestICS04Upgrade:testUpgradeCannotRecvNextUpgradePacket() (gas: 5266805)
+TestICS04Upgrade:testUpgradeCannotRecvNextUpgradePacket() (gas: 5266813)
 TestICS04Upgrade:testUpgradeCounterpartyAdvanceNextSequenceBeforeOpen() (gas: 5235961)
 TestICS04Upgrade:testUpgradeCrossingHelloIncompatibleProposals() (gas: 4405943)
 TestICS04Upgrade:testUpgradeFull() (gas: 57782504)
 TestICS04Upgrade:testUpgradeInit() (gas: 3068733)
 TestICS04Upgrade:testUpgradeNoChanges() (gas: 2471886)
 TestICS04Upgrade:testUpgradeOutOfSync() (gas: 3902195)
-TestICS04Upgrade:testUpgradeRelaySuccessAtCounterpartyFlushComplete() (gas: 5238569)
-TestICS04Upgrade:testUpgradeRelaySuccessAtFlushing() (gas: 5612538)
+TestICS04Upgrade:testUpgradeRelaySuccessAtCounterpartyFlushComplete() (gas: 5238577)
+TestICS04Upgrade:testUpgradeRelaySuccessAtFlushing() (gas: 5612554)
 TestICS04Upgrade:testUpgradeSendPacketFailAtFlushingOrFlushComplete() (gas: 4070944)
 TestICS04Upgrade:testUpgradeTimeoutAbortAck() (gas: 17679407)
 TestICS04Upgrade:testUpgradeTimeoutAbortConfirm() (gas: 21317099)
 TestICS04Upgrade:testUpgradeTimeoutUpgrade() (gas: 44263811)
-TestICS04Upgrade:testUpgradeToOrdered() (gas: 56495097)
-TestICS04Upgrade:testUpgradeToUnordered() (gas: 45103883)
+TestICS04Upgrade:testUpgradeToOrdered() (gas: 56495273)
+TestICS04Upgrade:testUpgradeToUnordered() (gas: 45104027)
 TestICS04UpgradeApp:testUpgradeAuthorizationChanneNotFound() (gas: 61712)
 TestICS04UpgradeApp:testUpgradeAuthorizationRePropose() (gas: 2565510)
 TestICS04UpgradeApp:testUpgradeAuthorizationRemove() (gas: 2473948)

contracts/core/26-router/IBCModuleManager.sol

@@ -22,7 +22,7 @@ contract IBCModuleManager is IBCHost, Context {
     }
 
     /**
-     * @dev claimCapability allows the IBC app module to claim a capability that core IBC passes to it
+     * @dev claimChannelCapability allows the IBC app module to claim a capability that core IBC passes to it
      */
     function claimChannelCapability(string calldata portId, string memory channelId, address addr) internal {
         if (channelCapabilities[portId][channelId] != address(0)) {
@@ -36,13 +36,15 @@ contract IBCModuleManager is IBCHost, Context {
      * It allows for a caller to check that a capability does in fact correspond to a particular name.
      */
     function authenticateChannelCapability(string calldata portId, string calldata channelId) internal view {
-        if (channelCapabilities[portId][channelId] != _msgSender()) {
-            revert IBCHostFailedAuthenticateChannelCapability(portId, channelId, _msgSender());
+        address msgSender = _msgSender();
+        if (channelCapabilities[portId][channelId] != msgSender) {
+            revert IBCHostFailedAuthenticateChannelCapability(portId, channelId, msgSender);
         }
     }
 
     /**
      * @dev lookupModuleByPort will return the IBCModule along with the capability associated with a given portID
+     * If the module is not found, it will revert
      */
     function lookupModuleByPort(string calldata portId) internal view virtual returns (IIBCModule) {
         address module = portCapabilities[portId];
@@ -54,6 +56,7 @@ contract IBCModuleManager is IBCHost, Context {
 
     /**
      * @dev lookupModuleByChannel will return the IBCModule along with the capability associated with a given channel defined by its portID and channelID
+     * If the module is not found, it will revert
      */
     function lookupModuleByChannel(string calldata portId, string calldata channelId)
         internal
@@ -70,13 +73,15 @@ contract IBCModuleManager is IBCHost, Context {
 
     /**
      * @dev lookupUpgradableModuleByPort will return the IBCModule along with the capability associated with a given portID
+     * If the module is not found, it will revert
      */
     function lookupUpgradableModuleByPort(string calldata portId) internal view returns (IIBCModuleUpgrade) {
         return IIBCModuleUpgrade(address(lookupModuleByPort(portId)));
     }
 
     /**
      * @dev canTransitionToFlushComplete checks if the module can transition to flush complete at the given upgrade sequence
+     * If the module is not found, it will revert
      */
     function canTransitionToFlushComplete(
         Channel.Order ordering,