Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider using more efficient solidity proto libraries #17

Open
hxrts opened this issue Apr 8, 2021 · 1 comment
Open

consider using more efficient solidity proto libraries #17

hxrts opened this issue Apr 8, 2021 · 1 comment

Comments

@hxrts
Copy link

hxrts commented Apr 8, 2021

from @adlerjohn:

They encode to storage, not memory https://github.com/datachainlab/ibc-solidity/blob/e5c5e622877e1c6c5269b4238889007dd135be13/contracts/core/types/ProtoBufRuntime.sol#L21
i.e. it'll cost like a billion gas to do anything. If you know them, tell them to use and contribute to my library!

  1. https://github.com/lazyledger/protobuf3-solidity-lib
  2. https://github.com/lazyledger/protobuf3-solidity
@bluele
Copy link
Member

bluele commented Apr 8, 2021

Thanks! We are currently using the encode function(e.g. this impl) generated by the generator instead of encodeStorage, but we would like to check the possibility that the lazyledger implementation might be more efficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants