Update value range from 2^40 to 2^100 #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Zhang <[email protected]>
|
Checked all of them have been updated |
Chengxuan
reviewed
Nov 5, 2024
zkp/js/test/anon_nullifier.js
Outdated
| @@ -14,23 +14,18 @@ | |||
| // See the License for the specific language governing permissions and | |||
There was a problem hiding this comment.
the format of this file is not consistent with other files. It should be auto formatted by prettier when running the test using npm t
Signed-off-by: Chengxuan Xing <[email protected]>
Chengxuan
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anticipating that users and use cases might need a bigger range to accommodate the token practice to use 18 decimals. Using [0, 2^100) as the range allows a token economy built on zeto to have a trillion tokens each with 18 decimals.