Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make commented demo tests work again #19

Open
TimoGlastra opened this issue Nov 14, 2022 · 1 comment
Open

Make commented demo tests work again #19

TimoGlastra opened this issue Nov 14, 2022 · 1 comment
Assignees

Comments

@TimoGlastra
Copy link
Member

TimoGlastra commented Nov 14, 2022

Tests: https://github.com/hyperledger/anoncreds-rs/blob/main/tests/anoncreds_demos.rs

Need in memory storage implementation (current tests made a start at this)

  • Identify what the (un)commented tests do/test
  • Pick a list of tests that are important/where it makes sense
  • Remove any commented code that doesn't test anything new

3000 of 3500 lines are still commented (85%). The tests are written for the Indy SDK, so we do have to update all code to work with AnonCreds RS. Goal is to reach a good level of testing, it's infeasible to update all tests from indy-sdk

@berendsliedrecht
Copy link
Contributor

After #150 is merged, we are at 1080/2850 working (30%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants