Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instead of having iOS XC framework, making it a universal XC Framework #201

Open
goncalo-frade-iohk opened this issue May 3, 2023 · 2 comments

Comments

@goncalo-frade-iohk
Copy link

Hello there.

I would like to propose that instead of having separate libraries for iOS and Mac.

You would probably just have to add the libraries you build for Darwin to the xcframework.
This would make the xcframework universal.

 - run: >
          ./build-xcframework.sh aarch64-apple-ios \
                                 aarch64-apple-ios-sim \
                                 x86_64-apple-ios \
                                 aarch64-apple-darwin \
                                 x86_64-apple-darwin \
                                 include
@swcurran
Copy link
Member

swcurran commented May 3, 2023

@blu3beri — what do you think of this idea? Helpful? Tried? Presumably, this would also be good for Askar and Indy-VDR, right?

@berendsliedrecht
Copy link
Contributor

Have not tried this, yet. However the FFI libraries, Python and JavaScript, use the dylib directly and not the xcframework. Making it universal would mean that we still have to publish the dylib separately and the xcframework for iOS would be bigger.

So if we were to do this, I would propose to either add it to the iOS one, making it slightly bigger, or create an additional one which would have everything meaning the iOS one can stay small.

I am also not too experienced with xcframeworks and how they fit in the Apple ecosystem, next to some superficial knowledge, so if I missed something please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants