Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missed 1.79 -> 1.84.1 rust version update #1324

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix missed 1.79 -> 1.84.1 rust version update #1324

wants to merge 1 commit into from
+2 −2

Conversation

JamesKEbert
Copy link
Contributor

Missed version updates from #1320 that are breaking some CI checks

@JamesKEbert
Copy link
Contributor Author

Note that the failing build-docker-vdrproxy check is expected

@gmulhearn
Copy link
Contributor

Ahhh I think the vdr proxy build might work if you bump the checkout version to match our new Indy-vdr version/commit that we use around the codebase.

I.e. changing this:

RUN git checkout c143268

@gmulhearn
Copy link
Contributor

Now we're on vdr commit b4dc08b instead

@gmulhearn
Copy link
Contributor

Also, if possible, I'd avoid raising the MSRV for our crates - which I believe the rust-version in cargo.toml enforces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamesKEbert @gmulhearn