Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shorten rolling increment to 32 #7909

Merged

Conversation

garyschulte
Copy link
Contributor

@garyschulte garyschulte commented Nov 22, 2024

PR description

simple change to state rolling increment for debug_setHead. This PR shortens this interval to 32.

Fixed Issue(s)

Discovered while verifying #7804, chain and state rolling with an interval of 512 can lead to out-of-memory.

confirmed by rolling state 209k blocks back on main to the block referenced in #7804. trace for the block in question attached

trace_block_21030627.json

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@garyschulte garyschulte enabled auto-merge (squash) November 22, 2024 16:09
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog?

@garyschulte garyschulte merged commit 4a629da into hyperledger:main Nov 24, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants