bump up to golang 1.23 version #206
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,11 @@ | ||
| module github.com/hyperledger/fabric-admin-sdk | ||
|
|
||
| go 1.23 | ||
|
|
||
| require ( | ||
| github.com/IBM/sarama v1.43.1 | ||
| github.com/Knetic/govaluate v3.0.0+incompatible | ||
| github.com/golang/mock v1.1.1 | ||
|
There was a problem hiding this comment. We should be using There was a problem hiding this comment. graph.txt to apply There was a problem hiding this comment. I don't see that behaviour. I wonder if you have locally some generated mocks that were created using github.com/golang/mock? If you get rid of the generated mocks, either with From this clean state, running either |
||
| github.com/grpc-ecosystem/go-grpc-middleware v1.4.0 | ||
| github.com/hashicorp/go-version v1.6.0 | ||
| github.com/hyperledger/fabric-gateway v1.5.0 | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not move the minimum required Go version beyond 1.22 while 1.22 is still a supported Go version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect that having a 2-digit
godirective and notoolchaindirective will cause problems for consumers. I think we don't see that in our tests since the e2e tests are within the same module so do not exercise the API in the same way that an end user would.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I will update to go 1.22 later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The go.mod is only really supposed to be updated using the go CLI commands now. To update the Go version to 1.22 with no automatically added toolchain directive, you probably need
go get [email protected] toolchain@none. See the Go Toolchains documentation; particularly the Managing Go version module requirements with go get section.