Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve receipts handling #34

Open
jimthematrix opened this issue Aug 6, 2021 · 0 comments
Open

Improve receipts handling #34

jimthematrix opened this issue Aug 6, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jimthematrix
Copy link
Contributor

Currently receipts are not produced and saved in the receipts DB until after the transaction has completed. This can be confusing when the client attempts to get the state of the transaction by querying on the receipt ID, where 404 will be returned.

A better design would be for the receipt to be saved in the DB with a pending state in the meanwhile, which gets updated to TransactionSuccess or TransactionFailure upon completion.
@jimthematrix jimthematrix added enhancement New feature or request good first issue Good for newcomers labels Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jimthematrix