Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update logos #1900

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Update logos #1900

merged 1 commit into from
Jan 24, 2025

Conversation

ryjones
Copy link
Contributor

@ryjones ryjones commented Jan 24, 2025

No description provided.

@ryjones ryjones requested a review from swcurran January 24, 2025 11:48
swcurran
swcurran previously approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the png logos be sized the same? I’m not a designer, but I would think depending on where the logos are being used, the logo size difference would matter.

That said, approving, so you can go ahead if this is not an issue.

@WadeBarnes WadeBarnes self-requested a review January 24, 2025 15:11
WadeBarnes
WadeBarnes previously approved these changes Jan 24, 2025
View reviewed changes
@ryjones
Copy link
Contributor Author

ryjones commented Jan 24, 2025

I can do another round

@ryjones
Update logo
fe34b62 
Remove old, unused assets

Signed-off-by: Ry Jones <[email protected]>
@ryjones ryjones dismissed stale reviews from WadeBarnes and swcurran via fe34b62 January 24, 2025 17:19
@ryjones
Copy link
Contributor Author

ryjones commented Jan 24, 2025

OK, I made the logo the same height, but it is a little wider.

swcurran
swcurran approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks — LGTM

@ryjones ryjones merged commit 6289187 into main Jan 24, 2025
8 checks passed
@ryjones ryjones deleted the logos branch January 24, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swcurran swcurran swcurran approved these changes

@WadeBarnes WadeBarnes WadeBarnes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryjones @swcurran @WadeBarnes