Ubuntu 22.04 Indy-Node Upgrade #1911
Conversation
Signed-off-by: GuillaumeBourque-QC <[email protected]>
|
Hi @R3CK0 — thanks for the PR. You need to sign the PR with your email per the DCO check — DCO - Developer Certificate of Origin - https://github.com/apps/dco. To fix, see: https://github.com/src-d/guide/blob/master/developer-community/fix-DCO.md. See the “details” by the failed checks for how to fix. Thanks. |
|
Right, will take care of that now |
collections. Tests can now be run Signed-off-by: Nicholas Massad <[email protected]>
of plenum in order to work on node in parralel Signed-off-by: Nicholas Massad <[email protected]>
Signed-off-by: Nicholas Massad <[email protected]>
|
I have updated some of the test files as well as added a utils to store some of the functions. The naming of the arguments will need to be revisited to align with those in the new packages once the tests are updated. I am currently unable to find the equivalent of indy.did in the new packages. |
setup.py
Outdated
| 'indy_vdr==0.4.0.dev5', | ||
| 'aries-askar==0.2.7', | ||
| 'indy-credx==0.3.1', |
There was a problem hiding this comment.
These are only used for testing, we do not want to add these dependencies to the main package.
setup.py
Outdated
| 'pytest-asyncio>=0.14.0', | ||
| 'indy_vdr==0.4.0.dev5', 'aries-askar==0.2.7', 'indy-credx==0.3.1'] |
There was a problem hiding this comment.
Recommend upgrading to the latest version of the packages:
indy_vdr: 0.4.3
aries-askar: 0.4.3
indy-credx: 1.1.1
There was a problem hiding this comment.
The latest askar is 0.4.3 — any reason for not using that? That is what ACA-Py is using — from the ACA-Py pyproject.toml:
# askar
aries-askar = ">=0.4.3"
There was a problem hiding this comment.
Note the issue with the published version of indy_vdr not being the latest, mentioned here; hyperledger/indy-vdr#335
There was a problem hiding this comment.
Was using the latest pu lished versions as to not get any errors. I Believe the issue was brought up. Will change in next commit
You should be able to find reference examples in this PR; hyperledger/indy-test-automation#125 |
Signed-off-by: Nicholas Massad <[email protected]>
Modified the ioflo package source to come from their repo istead of the release to include the changes in the new release of Colletions Package