Skip to content

Commit 4bfb938

Browse files
authored
fix: addressing comments on #656 (#657)
* fix: address comments
1 parent 085462b commit 4bfb938

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

projects/common/src/utilities/formatters/string/string-formatter.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ describe('String formatter', () => {
3636
expect(getStringsFromCommaSeparatedList('first,second, third ')).toEqual(
3737
expect.arrayContaining(['first', 'second', 'third'])
3838
);
39-
expect(getStringsFromCommaSeparatedList('first,second, ')).toEqual(expect.arrayContaining(['first', 'second']));
40-
expect(getStringsFromCommaSeparatedList('first')).toEqual(expect.arrayContaining(['first']));
39+
expect(getStringsFromCommaSeparatedList('first,second, ')).toEqual(['first', 'second']);
40+
expect(getStringsFromCommaSeparatedList('first')).toEqual(['first']);
4141
});
4242
});

projects/common/src/utilities/formatters/string/string-formatter.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ export const collapseWhitespace = (str: string): string =>
4545

4646
export const getStringsFromCommaSeparatedList = (text: string): string[] =>
4747
text
48-
.trim()
4948
.split(',')
5049
.map(part => part.trim())
5150
.filter(part => part !== '');

0 commit comments

Comments
 (0)