Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeouts on social.distributed.press #151

Open
fauno opened this issue Mar 15, 2024 · 4 comments
Open

Timeouts on social.distributed.press #151

fauno opened this issue Mar 15, 2024 · 4 comments
Assignees
Labels
bug / not working Something isn't working

Comments

@fauno
Copy link
Collaborator

fauno commented Mar 15, 2024

I'm getting timeouts while approving a Follow request and it's difficult to parse logs, so I'm not sure if the request is triggering fetches to remote instances and failing or some requests are happening at the same time.

I set the timeout to 1s to avoid crashing the CMS but this seems to low for current requests (but too high for B2B connections?)

@fauno
Copy link
Collaborator Author

fauno commented Mar 15, 2024

Now it worked, but I don't know why

@fauno
Copy link
Collaborator Author

fauno commented Apr 5, 2024

we discussed replying the request with a collection of requests statuses but i'm not sure now if i opened an issue about this, so i'm leaving this comment to not forget again

@catdevnull
Copy link
Collaborator

catdevnull commented Apr 25, 2024

This happens when POSTing the outbox as it sends a request to every following instance

https://github.com/hyphacoop/social.distributed.press/blob/3e9c803a050ef5342c16441fa048951eccae1f52/src/server/api/outbox.ts#L41

We should probably return instantly to the outbox request, and queue the requests to other instances (with p-queue). Maybe also set the amount to do parallel with something like p-map. Or ideally a queue that persists to disk (to also retry on failed.)

@fauno
Copy link
Collaborator Author

fauno commented Apr 25, 2024

This is important because the notification step during site build is going to take as long as the slowest instance (or a timeout)

@fauno fauno assigned sutty-coop and unassigned RangerMauve Apr 25, 2024
@RangerMauve RangerMauve transferred this issue from hyphacoop/social.distributed.press Apr 30, 2024
@RangerMauve RangerMauve moved this from Needs triage to Todo in Distributed Press Organizing Oct 10, 2024
@RangerMauve RangerMauve added the bug / not working Something isn't working label Oct 10, 2024
@RangerMauve RangerMauve self-assigned this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / not working Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

4 participants