Auto-follow when manuallyApprovesFollowers is present and false

[fauno]

An Actor with manuallyApprovesFollowers set to false should auto-accept Follow requests and dispatch an onapproved webhook. With this a website can control if they want to handle follows themselves or let the Social Inbox do that for them.

{
  "@context": [
    "https://www.w3.org/ns/activitystreams",
    {
      "manuallyApprovesFollowers": "as:manuallyApprovesFollowers"
    }
  ],
  "type": "Person",
  "manuallyApprovesFollowers": true,
}

[fauno]

Note APActor type doesn't include this attribute.

[fauno]

Something @catdevnull could implement early on M4

[catdevnull]

should this be available for all actors or just used in the announcements actor?

[RangerMauve]

All actors would be best IMO

[RangerMauve]

Hmm, maybe we can start with setting this flag in the setInfo call to start? Just worried we'd have cache invalidation issues and extra requests otherwise.

[fauno]

I meant for all actors yeah. @RangerMauve the Jekyll plugin sends an Update for the Actor object when it detects it changed, so we should be fine (we did this so profile pics and info was correctly updated)

[catdevnull]

isn't this (seemingly incorrectly) implemented by hyphacoop/social.distributed.press@2f97d57?

[sutty-coop]

Asignade a Agus - necesitamos su usuarie de Github

[RangerMauve]

Technically we have an alternative for this already in the account info when you create your account, but it might be useful to also pull this setting from the actor to simplify deployment further.

[RangerMauve]

I think we should add some sort of caching to our http requests first.

[fauno]

Technically we have an alternative for this already in the account info when you create your account, but it might be useful to also pull this setting from the actor to simplify deployment further.

Doesn't this line implement it?

https://github.com/hyphacoop/social.distributed.press/blob/main/src/server/apsystem.ts#L355

[RangerMauve]

Could you elaborate on your point? The line you linked to is empty for me.

[RangerMauve]

The functionality fetches from the info stored in the local store, not from the actor published on AP.

[fauno]

The functionality fetches from the info stored in the local store, not from the actor published on AP.

oooh i see!

[sutty-coop]

@fauno does this conversation above ☝ mean that @magush27 has to fix their code to fetch info from the actor instead of the local storage? If affirmative, let's ask Agus if they need any help changing this

[fauno]

No need! Just moved it to another part of the plugin and now it works!