-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No annotate/highlight button in google chat #1419
Comments
Unfortunately Google Chat is built in a way that is difficult for Hypothesis to support. If you access Google Chat by going to https://mail.google.com and then clicking the "Chat" link on the left, the Chat UI is hosted inside an iframe. By default the extension is only enabled for the top-level frame in a tab. If you go directly to https://chat.google.com then you get the Chat UI in a top level tab. However this runs into other problems. The Chat UI URL, excluding the fragment (part after the |
right, I observed that, the page-notes that Hypothesis creates are saved with URL https://mail.google.com/chat/u/0/ instead of https://mail.google.com/chat/u/0/#chat/space/AAAAXwToYzM. Two points: |
For Hypothesis to work as a collaborative annotation tool, everyone annotating the same document has to agree on which parts of the URL matter, for deciding which URLs are the same or different. Configurability for users and groups would create complexity there, so is something we would try to avoid. We'd be more likely to have a centralized database of rules for different sites, perhaps with ways for knowledgable users and website owners to contribute. With regards to fragments, that is a part of the URL that Hypothesis has always ignored, so there are probably quite a few parts of the system that would need to be modified in order to allow them to distinguish documents. I'm afraid this is probably something we are not going to do unless we have a more pressing use case. |
Extension Build: 1.1384.0.0 (Official Build)
Browser/OS Version 109.0.5414.74 (Official Build) Built on Ubuntu , running on Ubuntu 18.04 (64-bit)
Open google chat and select any word, no annotate/highlight button
However with google mail it works
The text was updated successfully, but these errors were encountered: