Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No annotate/highlight button in google chat #1419

Open
pinkeshb opened this issue Dec 1, 2023 · 3 comments
Open

No annotate/highlight button in google chat #1419

pinkeshb opened this issue Dec 1, 2023 · 3 comments

Comments

@pinkeshb
Copy link

pinkeshb commented Dec 1, 2023

Extension Build: 1.1384.0.0 (Official Build)
Browser/OS Version 109.0.5414.74 (Official Build) Built on Ubuntu , running on Ubuntu 18.04 (64-bit)

Open google chat and select any word, no annotate/highlight button
However with google mail it works

@robertknight
Copy link
Member

Unfortunately Google Chat is built in a way that is difficult for Hypothesis to support.

If you access Google Chat by going to https://mail.google.com and then clicking the "Chat" link on the left, the Chat UI is hosted inside an iframe. By default the extension is only enabled for the top-level frame in a tab. If you go directly to https://chat.google.com then you get the Chat UI in a top level tab. However this runs into other problems. The Chat UI URL, excluding the fragment (part after the # at the end), is the same for every chat (example: https://mail.google.com/chat/u/0/#chat/space/AAAAXwToYzM). This will cause Hypothesis to treat different chats as the same document.

@pinkeshb
Copy link
Author

pinkeshb commented Dec 2, 2023

right, I observed that, the page-notes that Hypothesis creates are saved with URL https://mail.google.com/chat/u/0/ instead of https://mail.google.com/chat/u/0/#chat/space/AAAAXwToYzM.

Two points:
A: Since some sites use the URI fragments more like query(Hypothesis already saves query part of URI), should saving the fragment part be configurable for individual sites, per group or account/extension?
B: Observed that the when I select text in google chat, instead of Hypothesis buttons, I see the Google chat related buttons(emoji buttons), can we use the right-click menu for such scenarios(like some other Web higlighters?)

@robertknight
Copy link
Member

Since some sites use the URI fragments more like query(Hypothesis already saves query part of URI), should saving the fragment part be configurable for individual sites, per group or account/extension?

For Hypothesis to work as a collaborative annotation tool, everyone annotating the same document has to agree on which parts of the URL matter, for deciding which URLs are the same or different. Configurability for users and groups would create complexity there, so is something we would try to avoid. We'd be more likely to have a centralized database of rules for different sites, perhaps with ways for knowledgable users and website owners to contribute.

With regards to fragments, that is a part of the URL that Hypothesis has always ignored, so there are probably quite a few parts of the system that would need to be modified in order to allow them to distinguish documents. I'm afraid this is probably something we are not going to do unless we have a more pressing use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants