Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox v130+ fixes improvements #6559

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Firefox v130+ fixes improvements #6559

merged 3 commits into from
Sep 18, 2024

Conversation

acelaya
Copy link
Contributor

@acelaya acelaya commented Sep 17, 2024

Applied some improvements to the fixes from #6548 and #6541 that were suggested in #6548 (review) and #6541 (review)

@acelaya acelaya changed the title Firefox fix improvements Firefox annotation anchoring fix improvements Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.43%. Comparing base (1d71f38) to head (ac56b93).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6559   +/-   ##
=======================================
  Coverage   99.43%   99.43%           
=======================================
  Files         270      270           
  Lines       10225    10225           
  Branches     2419     2419           
=======================================
  Hits        10167    10167           
  Misses         58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya changed the title Firefox annotation anchoring fix improvements Firefox fixes improvements Sep 17, 2024
@robertknight robertknight changed the title Firefox fixes improvements Firefox v130+ fixes improvements Sep 18, 2024
@acelaya acelaya merged commit 0685de0 into main Sep 18, 2024
4 checks passed
@acelaya acelaya deleted the firefox-fix-improvements branch September 18, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants