Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make JavaScript programmatic link clicks open in a new tab and leave Via #181

Open
seanh opened this issue May 20, 2021 · 0 comments
Open

Comments

@seanh
Copy link
Collaborator

seanh commented May 20, 2021

When a user clicks on a link in Via it opens the link target in a new tab that is not proxied by Via: #9

But when the navigation is triggered by programmatically clicking the link using JavaScript this still navigates the original tab and does not leave Via. For example Google and Bing search results do this kind of navigation.

We need to intercept these programmatic link navigations and make them open in a new, non-proxied tab like normal link navigations do.

A one-line JavaScript solution that works for Google and Bing was given in this Slack thread: https://hypothes-is.slack.com/archives/C1M8NH76X/p1621418996025700

Master issue for all kinds of JavaScript navigations: #183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant