New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client is not loaded on page with malformed `<head>` tag #41

Open

robertknight opened this issue Dec 15, 2020 · 2 comments

Labels

bug

Member

robertknight commented Dec 15, 2020

The Hypothesis client does not load when http://sites.fas.harvard.edu/~chaucer/special/litsubs/romances/sg-prt1.htm is proxied through viahtml. It does however load when this page is proxied through legacy Via.

A reduced test case is available here: https://hypothesis-via.s3-us-west-1.amazonaws.com/test-pages/no-head.html. It has the following HTML:

D>
</HEAD>
<BODY>
TEST
</BODY>
</HTML>

Compare https://viahtml3.hypothes.is/proxy/https://hypothesis-via.s3-us-west-1.amazonaws.com/test-pages/no-head.html against https://via.hypothes.is/https://hypothesis-via.s3-us-west-1.amazonaws.com/test-pages/no-head.html.

Original report: https://hypothes-is.slack.com/archives/C2BLQDKHA/p1607984782401800

Member Author

robertknight commented Dec 15, 2020

I've checked that the issue is not related to the case of the tags but to the leading D>. The client is not loaded with this HTML:

D>
</head>
<body>
TEST
</body>
</html>

But is loaded with this HTML:

</head>
<body>
TEST
</body>
</html>

mattdricker commented Dec 15, 2020

Reported by user: https://app.hubspot.com/contacts/6291320/ticket/261922020/

klemay added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment