Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

I'm adding github build action on windows... #14

Open
hradec opened this issue Apr 14, 2021 · 5 comments
Open

I'm adding github build action on windows... #14

hradec opened this issue Apr 14, 2021 · 5 comments

Comments

@hradec
Copy link

hradec commented Apr 14, 2021

Hi there...
I just wan't to give a heads up so you don't have to worry about github actions to build gaffer dependencies.

I'm working on it right now and I'll do a pull request to this fork when I have it fully working on my with your latest code!
I'm following the windows build instructions you added to the README. Thanks for that!

The only difference is that I'm using BASH in windows instead of CMD/Powershell, so the action shell code stays almost the same on all platforms.

I'm planning on doing it for linux and osx as well, but since I have a in-house build system for linux already, that's lower priority. But we're planning on migrating all our builds to github, so I'll do it later on, if no-one else have done it yet.

@ericmehl
Copy link
Member

That sounds great! I see that they increased the time limit to six hours for a build now, so hopefully that will be enough time to build all the dependencies.

Besides potentially the time limit, you'll run into problems building Cortex as things stand right now. On my internal CI, I've been building in separate steps

  1. Dependencies without Cortex
  2. Cortex from my msvc2017 branch https://github.com/hypothetical-inc/cortex/tree/msvc2017
  3. Gaffer from appropriate release number branch

So for all the Gaffer dependencies, including Cortex, you'd need to get Cortex from that msvc2017 branch. I'm working now on getting all of my changes merged into the master IE repository so once that's done and makes its way to a release we can update the dependencies to download the release like the Linux build does.

@ericmehl
Copy link
Member

Ok, I have all of my Window-specific commits approved and part of IE master https://github.com/ImageEngine/cortex. They are not in a release yet but when they make their way to a release, I can update the dependencies build to grab it and build Cortex on Windows as part of the overall dependencies.

@ericmehl
Copy link
Member

The new 3.0.0 release that I just put up gets its Cortex from https://github.com/ImageEngine/cortex, so now all of the dependencies for Gaffer are built as part of this repository!

@hradec
Copy link
Author

hradec commented Sep 16, 2021

That's great news!! I'm finally finishing the github CI for gaffer windows, and I'll continue work on this one right after.

Btw, have you considered building all using MinGW instead of MSVC? Back in 2008, I got cortex to compile on windows, and found mingw was much simpler to build with than msvc at the time.

@ericmehl
Copy link
Member

Btw, have you considered building all using MinGW instead of MSVC? Back in 2008, I got cortex to compile on windows, and found mingw was much simpler to build with than msvc at the time.

I haven't looked into it - I'd rather stick to as much of a true Windows build as possible. I don't have any specific evidence but I'm wary of mixing Linux-like development and Windows any more than necessary.

Also flagging that I released a new set of dependencies - 3.1.0 is out now!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants