Regression on 0.44.1 regarding shikane

[leiserfg]

Already reported ? *

• I have searched the existing open and closed issues.

Regression?

Yes

System Info and Version

Hyprland 0.44.1

Description

After 0.44.1 shikane does not work again: after disconnecting the external monitor the internal one does not kick in. I tested the related commits in the release:

With ad46257 shikane works fine but it makes many apps misbehave (not even the wallpaper works)
With 8405aa1 the apps work again but then shikane does not work anymore.

How to reproduce

See #7571

Crash reports, logs, images, videos

No response

[vaxerski]

wayland_debug of shikane pls?

[leiserfg]

env WAYLAND_DEBUG=1 shikane 2>&1 |tee /tmp/wayland.log
wayland.log

env SHIKANE_LOG=trace shikane 2>&1 | grep Event::
shikane.log

[leiserfg]

I don't see the Finished events again, 😢

[vaxerski]

yabba dabba doo refcounting oopsie woohoo

[vaxerski]

should be fixed lmk

[Mikilio]

Just tried master and I still have the issue.

Hyprland 0.44.0 built from branch  at commit 0b29caf9ab86518ff474eed5e7d19c12f96ebbd0  ().
Date: 2024-10-26
Tag: , commits: 
built against aquamarine 0.4.3


flags set:
debug

[vaxerski]

can you get a WAYLAND_DEBUG log?

[Mikilio]

Here it is:
waylandt.log

I started running Hyprland connected to my dock with my laptop being disabled by shikane:

1. turn off my service for shikane
2. running env WAYLAND_DEBUG=1 shikane 2>&1 |tee /tmp/wayland.log
3. disconnecting from my dock (laptop screen stays black)
4. switching to VT and logging in
5. running pkill shikane
6. copying the logs
7. restarting shikane service
8. switching back to Hyprland (at this point on my laptop was actually displaying a workspace)
9. connect to the dock (Hypland crashes)

[vaxerski]

finished logs are there tho huh? @leiserfg does it also not work for you?

[leiserfg]

I'm back from NixCon. Tested in a3d3b4f and it works for me.

[vaxerski]

closing then @Mikilio you can open a separate one