From 8deeec45cec4f659eec2d574a388a4b9bf9ead64 Mon Sep 17 00:00:00 2001
From: hzrd149 <github@hzrd149.com>
Date: Sat, 31 Aug 2024 06:52:16 -0500
Subject: [PATCH] fix cached forms not being removed when submitted

---
 src/hooks/use-cache-form.ts                | 20 +++++++++++---------
 src/views/thread/components/reply-form.tsx |  1 +
 2 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/src/hooks/use-cache-form.ts b/src/hooks/use-cache-form.ts
index a76f0ab41..48e725409 100644
--- a/src/hooks/use-cache-form.ts
+++ b/src/hooks/use-cache-form.ts
@@ -14,12 +14,14 @@ export default function useCacheForm<TFieldValues extends FieldValues = FieldVal
   const log = useMemo(() => (key ? logger.extend(`CachedForm:${key}`) : () => {}), [key]);
   const storageKey = key && "cached-form-" + key;
 
-  const stateRef = useRef<UseFormStateReturn<TFieldValues>>(state);
-  stateRef.current = state;
+  const isSubmitted = useRef<boolean>(state.isSubmitted);
+  isSubmitted.current = state.isSubmitted;
 
-  // NOTE: this watches the state
-  state.isDirty;
-  state.isSubmitted;
+  const isSubmitting = useRef<boolean>(state.isSubmitting);
+  isSubmitting.current = state.isSubmitting;
+
+  const isDirty = useRef<boolean>(state.isDirty);
+  isDirty.current = state.isDirty;
 
   useEffect(() => {
     if (!storageKey) return;
@@ -44,10 +46,10 @@ export default function useCacheForm<TFieldValues extends FieldValues = FieldVal
 
     // save previous key on change or unmount
     return () => {
-      if (stateRef.current.isSubmitted) {
+      if (isSubmitted.current || isSubmitting.current) {
         log("Removing because submitted");
         localStorage.removeItem(storageKey);
-      } else if (stateRef.current.isDirty) {
+      } else if (isDirty.current) {
         const values = getValues();
         log("Saving form", values);
         localStorage.setItem(storageKey, JSON.stringify(values));
@@ -58,10 +60,10 @@ export default function useCacheForm<TFieldValues extends FieldValues = FieldVal
   const saveOnClose = useCallback(() => {
     if (!storageKey) return;
 
-    if (stateRef.current.isSubmitted) {
+    if (isSubmitted.current || isSubmitting.current) {
       log("Removing because submitted");
       localStorage.removeItem(storageKey);
-    } else if (stateRef.current.isDirty) {
+    } else if (isDirty.current) {
       const values = getValues();
       log("Saving form", values);
       localStorage.setItem(storageKey, JSON.stringify(values));
diff --git a/src/views/thread/components/reply-form.tsx b/src/views/thread/components/reply-form.tsx
index 331b93cfe..80a10a2ad 100644
--- a/src/views/thread/components/reply-form.tsx
+++ b/src/views/thread/components/reply-form.tsx
@@ -45,6 +45,7 @@ export default function ReplyForm({ item, onCancel, onSubmitted, replyKind = kin
     },
     mode: "all",
   });
+
   const clearCache = useCacheForm<{ content: string }>(`reply-${item.event.id}`, getValues, reset, formState);
 
   const contentMentions = getPubkeysMentionedInContent(getValues().content);