Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to match @blueboxd and push firefox compatibility to 10.7 #33

Open
1 of 4 tasks
Tracked by #1
i3roly opened this issue Feb 24, 2025 · 2 comments
Open
1 of 4 tasks
Tracked by #1

try to match @blueboxd and push firefox compatibility to 10.7 #33

i3roly opened this issue Feb 24, 2025 · 2 comments

Comments

@i3roly
Copy link
Owner

i3roly commented Feb 24, 2025

as of 136, 10.7 is mostly usable. there are a few near-fatal cases however:

  • if the user manages to muck up their profile, or run an older firefox than they did previously, the profile checking in toolkit/xre will cause the browser to hang after you click "OK" (missing profile) or "create new profile". (fixed by the time i push either 136_0_BUILD3 or 136_0_RELEASE)
  • there are still sharp corners in the titlebar.
  • there is something strange going on with the javascript. the troubleshooting page is completely empty and fires an NS_ERROR_UNEXPECTED that has to be investigated
  • the pocket feature is not visible. i have no idea as to why, but the links on the pocket splash page are present if you hover the cursor around the right area.
@i3roly i3roly mentioned this issue Feb 24, 2025
5 tasks
Repository owner deleted a comment from RJVB Feb 25, 2025
@Wowfunhappy
Copy link

if the user manages to muck up their profile, or run an older firefox than they did previously, the profile checking in toolkit/xre will cause the browser to hang after you click "OK" (missing profile) or "create new profile".

Depending on how stubborn this issue is, it may make sense to just write a separate implementation. For example, I could pretty easily write a Python script that:

  1. Check if the lastVersion listed in compatibility.ini in the Firefox profile is newer than the version in Firefox.app/Contents/Resources/platform.ini.
  2. If it is, display a dialog asking the user if they'd like to delete the profile and start Firefox, or quit.
  3. If the user says to delete the profile, delete the profile folder.

Let me know if you'd like me to write a script like this! The one thing is that I might have to disallow using multiple profiles, unless Firefox can expose which profile it is about to open.

Repository owner deleted a comment from RJVB Feb 26, 2025
i3roly added a commit that referenced this issue Feb 27, 2025
it seems there is an issue when deleting the IOParentThreads on 10.7,
since they cause a block and users that have a newer profile than the
current firefox will accept, are left with no way to fix it without
deleting their entire profiles directory. (see #33)

this "fix" is hopefully temporary, but it does provide an answer for now
at least
i3roly added a commit that referenced this issue Feb 27, 2025
it seems there is an issue when deleting the IOParentThreads on 10.7,
since they cause a block and users that have a newer profile than the
current firefox will accept, are left with no way to fix it without
deleting their entire profiles directory. (see #33)

this "fix" is hopefully temporary, but it does provide an answer for now
at least
i3roly added a commit that referenced this issue Feb 27, 2025
it seems there is an issue when deleting the IOParentThreads on 10.7,
since they cause a block and users that have a newer profile than the
current firefox will accept, are left with no way to fix it without
deleting their entire profiles directory. (see #33)

this "fix" is hopefully temporary, but it does provide an answer for now
at least
@Wowfunhappy
Copy link

there are still sharp corners in the titlebar.

@krackers can probably help with this!

For context, we're talking about:

Image

See also: https://stackoverflow.com/questions/9447645/nswindow-alternative-to-setopaqueno/78213126#78213126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants