Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for upper and lower bound #229

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

annavolp
Copy link
Collaborator

@annavolp annavolp commented Nov 22, 2024

Closes #198

Changes made to solve the bug: when selecting upper and lower bounds of the x and y coordinates, the sources were placed in the wrong position. Rotation of 90 degrees with respect to SolarOrbiter and the roll_angle is now taken into account.

  • stx_vis_fwdfit_pso: convertion from HPC to STIX coordinate frame (if the (x,y) location is set by the user); upper and lower bound transformation from the Solar Orbiter coordinate frame to the STIX coordinate frame;
  • vis_fwdfit_pso and vis_fwdfit_func_pso: roll angle is taken into account. It is also taken into account that the coordinates of the position are searched in a rectangle centered on (0,0).

@samaloney
Copy link
Collaborator

Great thanks @annavolp I see this is a draft does it still need work/testing or can it be merged?

@annavolp annavolp marked this pull request as ready for review November 27, 2024 22:21
@annavolp
Copy link
Collaborator Author

Yes, it is now ready to be merged. Thank you, @samaloney

@samaloney samaloney merged commit c5a3310 into i4Ds:master Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using .lower_bound and .upper_bound for location in forward fit gives wrong results
2 participants