Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some data in AUX ephemeris files can be wrong #402

Open
FredSchuller opened this issue Oct 8, 2024 · 11 comments
Open

Some data in AUX ephemeris files can be wrong #402

FredSchuller opened this issue Oct 8, 2024 · 11 comments
Assignees
Milestone

Comments

@FredSchuller
Copy link

In some cases, I noticed that the values in column roll_angle_rpy in the AUX ephemeris files is not correct. This column contains three numbers (roll angle, yaw and pitch), which come from the Spice kernels. When the AUX files is generated before the as-flown attitude kernel is available, these numbers come from the predicted attitude and can be significantly off.

For example, in solo_L2_stix-aux-ephemeris_20240325_V02U.fits the values of yaw reach 100'' but the true (as-flown) pointing was only at 38'' off-centre.
The same is true for 20240328.

@samaloney
Copy link
Collaborator

Any files with ending with U are not final for exactly this reason when we publish/finalise them we update the spice info and remove the U.

@FredSchuller
Copy link
Author

Yes but so far these files are never updated (as far as I can see), and the one and only version available can be faulty...
This should be fixed even before the files are considered as final and ready to be published, since this info is required to generate images with correct astrometry.
We had a discussion with @nicHoch on that topic but we didn't come to a solution yet.

@nicHoch
Copy link
Collaborator

nicHoch commented Oct 10, 2024

we only do the updates in the headers so far. We also need a update-step for this column

@samaloney
Copy link
Collaborator

Hum but not only this column any spice derived information

@nicHoch
Copy link
Collaborator

nicHoch commented Oct 10, 2024

my understanding is that only the pointing information differs significant from predicted to flown all other data is around timing and this works well. Is that not the case?

@FredSchuller
Copy link
Author

yes that should be the case, other info like solar disk size is not going to change

@samaloney
Copy link
Collaborator

Yea the pointing is the most different but the timing, position etc can all change so to be consistent would need to update them all I think? For example the angular size of the disk is based on the standard physical size of the sun and the distance.

@FredSchuller
Copy link
Author

but currently the pipeline generates these AUX files as soon as new HK telemetry is available and they are never updated, right?

@nicHoch
Copy link
Collaborator

nicHoch commented Oct 10, 2024

currently the AUX files get not updated as we still do not deliver this files to SOAR. (i got a mail from Helen we are finally close now)
all other products will gets updated on the publish to SOAR step
and this will happen to the AUX (new ANC) files as well. BUT yes we have to think about also to update some data columns - see above (this is not implemented so far)

@samaloney
Copy link
Collaborator

Currently but we had process to update them when they are published them to the SOAR. But with the whole L1 vs ancillary thing we wanted to wait until that was resolved before we started to publish them.

@samaloney samaloney added this to the v1.5.0 milestone Oct 25, 2024
@samaloney
Copy link
Collaborator

Partially addressed in #405

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants