Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TORConfiguration controlSocket issue with spaces in path #16

Closed
chrisballinger opened this issue Feb 5, 2017 · 5 comments
Closed

TORConfiguration controlSocket issue with spaces in path #16

chrisballinger opened this issue Feb 5, 2017 · 5 comments

Comments

@chrisballinger
Copy link
Member

I think any of the TORConfiguration options with paths/urls can break if there are spaces in them
@conradev
Copy link
Member

conradev commented Feb 7, 2017

This was formerly blocked on #18753, but now that the issue is resolved, I think you should be able to modify TORConfiguration to add quotes to all path names and get it to work 😄

A PR would definitely be welcome!

@chrisballinger
Copy link
Member Author

Ah yeah, I forgot to mention I added escaped quotes but it still didn't work. (This is using 0.2.9.9)

@conradev
Copy link
Member

conradev commented Feb 7, 2017 •
edited
Loading

Oh, oops! This is because ControlSocket is actually deprecated and doesn't support spaces (see ticket). TORConfiguration really should be using ControlPort with the unix: prefix.

@chrisballinger
Copy link
Member Author

That explains it. :)

Thanks!

@conradev
Copy link
Member

conradev commented Feb 9, 2017

Closing because #17

@conradev conradev closed this as completed Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@conradev @chrisballinger