Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to add via SwiftUI package manager #78

Open
BenGWeeks opened this issue Apr 24, 2023 · 9 comments
Open

Request to add via SwiftUI package manager #78

BenGWeeks opened this issue Apr 24, 2023 · 9 comments

Comments

@BenGWeeks
Copy link

Ability to simply add via the swift package manager would be awesome.

Anyone able to give some advice on steps to manually add this framework into a SwiftUI project (actually a Nostr client, Damus).

@BenGWeeks BenGWeeks changed the title Request Request to add via SwiftUI package manager Apr 24, 2023
@Fonta1n3
Copy link

Fonta1n3 commented Apr 24, 2023

I can definitely help with that! Not the package itself but getting it running on Damus.

@BenGWeeks
Copy link
Author

That would be awesome thanks @Fonta1n3.

This is the progress so far:

https://github.com/BenGWeeks/damus/tree/tor-support

Let me know if you you would like contribute access!

Will be submitting this as a PR.

@Fonta1n3
Copy link

That would be awesome thanks @Fonta1n3.

This is the progress so far:

https://github.com/BenGWeeks/damus/tree/tor-support

Let me know if you you would like contribute access!

Will be submitting this as a PR.

Hey for sure, I would love to contribute. No guarantees but I will try.

@BenGWeeks
Copy link
Author

Invited!

@tladesignz
Copy link
Member

Interesting. Are you going to create a PR? Let me know how this goes. I always thought SPM is only for Swift stuff, but that ssems to be uninformed/outdated?

@BenGWeeks
Copy link
Author

Interesting. Are you going to create a PR? Let me know how this goes. I always thought SPM is only for Swift stuff, but that ssems to be uninformed/outdated?

I've only started SwiftUI development since December or so my knowledge is limited.

Yes, the iCepa/Tor.framework project can be made compatible with Swift Package Manager, even if it is not a pure Swift project. Swift Package Manager can handle projects with mixed-language sources, such as Objective-C and Swift, as long as the appropriate configurations are in place.

Yes, I think I may have a go at submitted a PR to add Swift Package Manager to this repo if desirable. I assume others would find it useful.

@BenGWeeks
Copy link
Author

Related: daltoniam/Starscream#971

@BenGWeeks
Copy link
Author

It looks like creating the Swift Packager Manager would probably require more knowledgeable people of the framework due to package dependencies. Any plans to implement this? Would make it a lot easier to integrate into XCode projects I believe.

@tladesignz
Copy link
Member

Package dependencies?
The only dependencies here are Tor itself, which is written in C. (Along with some dependencies it has: libevent, OpenSSL, xz and some system-provided libraries.)

Does SPM support Git submodules and calling shell build scripts? If not, this is doomed to fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants