Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test build during the week #6

Open
Gonza10V opened this issue Jun 19, 2024 · 7 comments
Open

Test build during the week #6

Gonza10V opened this issue Jun 19, 2024 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@Gonza10V
Copy link

the script got 7 out of 10 parts.

@Gonza10V Gonza10V added the bug Something isn't working label Jun 19, 2024
@jguillen15
Copy link

jguillen15 commented Jun 24, 2024

It seems there are 2 main errors:

  • In scripts/test/test_import.py::TestImportParts::test_all_import_types, 2 Sequences couldn't be retrieved :
    'http://sevahub.es/public/Canonical/cd_OriT' and 'http://sevahub.es/public/Canonical/lacZ_pUC19', so when the comparison is made for the test(against the comparison file we have) it fails. When I try to go to those links they don't exist anymore, so my guess is that the sequences were deleted and therefore couldn't be retrieved.
  • In scripts/test/test_import.py::TestImportParts::test_import, the generated NCBI_GenBank_imports.gb file is not identical to what it is expected to be.

@jakebeal
Copy link
Contributor

It looks like SevaHub no longer has any of its public data accessible. I've emailed Angel, but for now let's just take those out of the set of devices that are being tested.

With regards to the NCBI imports, have you checked what the difference is? If it's due to NCBI changing what its contents are, then we should just update the file contents to match the current contents.

@jguillen15
Copy link

jguillen15 commented Jun 25, 2024

I just checked it, it seems that NCBI changed some metadata: https://www.ncbi.nlm.nih.gov/nuccore/JWYZ01000115.1 (I assumed this is the sequence that is being used in the test)
This is the file we are using: https://github.com/iGEM-Engineering/iGEM-actions/blob/main/scripts/test/test_files/NCBI_GenBank_imports.gb
I changed the file and ran the test again, but it is still failing and created one more issue, with the package.nt collated file.
I will keep investigating further.

@jakebeal
Copy link
Contributor

Yes, looks like the metadata has changed, so please set up a pull request updating to the new metadata.
Also, per the message from Angel, the SevaHub sequences should be back up again.

@jguillen15
Copy link

jguillen15 commented Jun 26, 2024

Yes, I can see the SevaHub sequences back up again and passing the test!
However, replacing the NCBI_GenBank_imports.gb file with the new metadata didn't solve the issue.
There seems to be a confusion regarding the sequence URL: https://www.ncbi.nlm.nih.gov/nuccore/JWYZ01000115.1
During the test, a file with the same content is generated in a temporary subdirectory, but it has the URL : https://www.ncbi.nlm.nih.gov/nuccore/JWYZ01000115_1
This small change in the URL, from "." to "_", redirects to a search page rather than to the Genbank sequence itself.
I have trying to understand why this change is introduced in the test, but I haven't figured it out yet.

@jakebeal
Copy link
Contributor

jakebeal commented Jul 2, 2024

That URL isn't necessarily wrong - an SBOL displayID property isn't allowed to have a "." in it, so when the identifier is converted to SBOL, the JWYZ01000115.1 would, in fact, be likely to change to JWYZ01000115_1, which is not expected to be a literal URL for NCBI.

I don't think that's actually where your error actually is, however, since the error you're getting is comparison of the .gb files, and that URL isn't in the .gb file anywhere anyway. You'll need to look at what the actual difference is that's causing the error report.

@Gonza10V Gonza10V closed this as completed Jul 3, 2024
@jakebeal
Copy link
Contributor

jakebeal commented Jul 3, 2024

Actions are still failing in the develop branch, so I don't think this is done until we get in a PR that fixes this.

@jakebeal jakebeal reopened this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants