Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ced2go doesn't work with DST files #24

Open
dudarboh opened this issue Jan 22, 2024 · 0 comments
Open

ced2go doesn't work with DST files #24

dudarboh opened this issue Jan 22, 2024 · 0 comments

Comments

@dudarboh
Copy link
Member

dudarboh commented Jan 22, 2024

Issue

ced2go is expected to work with DST files if one specifies a -v flag to choose DSTViewer.
This modifies the default template steering file ced2go-template.xml to use DSTViewer instead of the default one.

If the user specifies the detector geometry with a flag -d, the default template steering file is changed to ced2go-template-DD4.xml, which does not work with DST files.
The ced2go-template-DD4.xml looks very different and incomplete compared to ced2go-template.xml.
It doesn't have the DSTViewer processor defined and always uses the default CEDViewer, thus also ignoring the -v flag completely.

Note that a user is required to define the detector geometry with a flag -d; otherwise, the code exits.

CEDViewer/ced2go/ced2go

Lines 108 to 110 in eec6d23

if not os.path.isfile(detector):
print ("Error: Gearfile \"" + detector + "\" not found!")
sys.exit()

This means ced2go is completely unusable for DST files.

Workarounds

Run the DSTViewer steering file directly with Marlin, e.g.:

source /cvmfs/ilc.desy.de/sw/x86_64_gcc82_centos7/v02-02-03/init_ilcsoft.sh
glced&
Marlin MarlinStdRecoViewerDST.xml   --global.GearXMLFile=Gear/gear_ILD_l5_o1_v02.xml   --global.LCIOInputFiles=filename.slcio

But it doesn't work with dd4hep geometry and requires obsolete Gear geometry files.

Additionally, a user should know where the MarlinStdRecoViewerDST.xml is located.
Using the iLCSoft environment, I managed to find it, but using key4hep, I did not.

Another workaround is to add a DSTViewer processor to the user's steering file.

How to fix

Add -v flag support to the ced2go-template-DD4.xml like in the ced2go-template.xml.

An even better option would be to use only one general template file and not have two.
They don't seem very different, so compressing them into a single steering file should be straightforward.

P.S.

Is there a viewer option for mini-DSTs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant