Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shopware 6 PHPStan Linter #18

Open
iMiMWeis opened this issue Feb 29, 2024 · 1 comment
Open

Shopware 6 PHPStan Linter #18

iMiMWeis opened this issue Feb 29, 2024 · 1 comment

Comments

@iMiMWeis
Copy link
Contributor

Static code analysis finished.

Warnings of the static code analysis:

------ -------------------------------------------------------------------------------- 
  Line   src/Service/PasswordPathService.php                                             
 ------ -------------------------------------------------------------------------------- 
  27     Parameter $event of method                                                      
         ImiDiPasswordProtectedPages\Service\PasswordPathService::checkPasswordInPath()  
         has invalid type                                                                
         Shopware\Storefront\Framework\Cache\Event\HttpCacheHitEvent.                    
  61     Parameter $event of method                                                      
         ImiDiPasswordProtectedPages\Service\PasswordPathService::checkAuthenticated()   
         has invalid type                                                                
         Shopware\Storefront\Framework\Cache\Event\HttpCacheHitEvent.                    
  63     Class Shopware\Storefront\Framework\Cache\Event\HttpCacheHitEvent was           
         not found while trying to analyse it - discovering symbols is                   
         probably not configured properly.                                               
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols             
  64     Class Shopware\Storefront\Framework\Cache\Event\HttpCacheHitEvent was           
         not found while trying to analyse it - discovering symbols is                   
         probably not configured properly.                                               
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols             
  72     Parameter $event of method                                                      
         ImiDiPasswordProtectedPages\Service\PasswordPathService::findNavigation()       
         has invalid type                                                                
         Shopware\Storefront\Framework\Cache\Event\HttpCacheHitEvent.                    
 ------ -------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------- 
  Line   src/Storefront/Controller/PasswordPageController.php                   
 ------ ----------------------------------------------------------------------- 
  37     Call of internal method Symfony\Component\HttpFoundation\Request::get  
         Please refrain from using methods which are annotated with @internal   
         in the Shopware 6 repository.                                          
  47     Call of internal method Symfony\Component\HttpFoundation\Request::get  
         Please refrain from using methods which are annotated with @internal   
         in the Shopware 6 repository.                                          
 ------ ----------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------------------- 
  Line   src/Subscriber/CheckPasswordSubscriber.php                                            
 ------ -------------------------------------------------------------------------------------- 
  33     Class Shopware\Storefront\Framework\Cache\Event\HttpCacheHitEvent not                 
         found.                                                                                
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                   
  57     Parameter $event of method                                                            
         ImiDiPasswordProtectedPages\Subscriber\CheckPasswordSubscriber::onCachedPageLoaded()  
         has invalid type                                                                      
         Shopware\Storefront\Framework\Cache\Event\HttpCacheHitEvent.                          
  60     Class Shopware\Storefront\Framework\Cache\Event\HttpCacheHitEvent was                 
         not found while trying to analyse it - discovering symbols is                         
         probably not configured properly.                                                     
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                   
  62     Class Shopware\Storefront\Framework\Cache\Event\HttpCacheHitEvent was                 
         not found while trying to analyse it - discovering symbols is                         
         probably not configured properly.                                                     
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                   
 ------ -------------------------------------------------------------------------------------- 

 [ERROR] Found 11 errors                                                        

@amenk
Copy link
Member

amenk commented Feb 29, 2024

How are you running the linter locally?

iMiMWeis added a commit that referenced this issue Mar 1, 2024
iMiMWeis added a commit that referenced this issue Mar 8, 2024
#18 fix PasswordPageController to comply with SW Linter
iMiMWeis added a commit that referenced this issue Mar 11, 2024
amenk added a commit that referenced this issue Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants