Skip to content

Commit 3da2376

Browse files
authored
Remove need for token based depoyment. (#335)
This pull request includes several important changes to the GitHub Actions workflow for releases. The changes focus on configuring the environment, updating permissions, and improving the build and publish steps. ### Workflow configuration: * [`.github/workflows/release.yml`](diffhunk://#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34R13-R17): Added the `environment: release` setting to the `deploy` job to specify the environment for the release. ### Permissions: * [`.github/workflows/release.yml`](diffhunk://#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34R13-R17): Added `id-token: write` permission, which is mandatory for trusted publishing. ### Build and publish steps: * [`.github/workflows/release.yml`](diffhunk://#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34L35-R44): Split the build and publish steps into two separate actions. The build step now only builds the package distribution, and the publish step uses the `pypa/gh-action-pypi-publish@release/v1` action to publish the package distributions to PyPI.
1 parent 6cf2723 commit 3da2376

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

.github/workflows/release.yml

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,11 @@ on:
1010
jobs:
1111
deploy:
1212
runs-on: ubuntu-latest
13+
environment: release
14+
15+
permissions:
16+
# IMPORTANT: this permission is mandatory for trusted publishing
17+
id-token: write
1318

1419
steps:
1520
- uses: actions/checkout@v4
@@ -32,10 +37,8 @@ jobs:
3237
ref: "main"
3338
env:
3439
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
35-
- name: Build and publish to PyPi
36-
env:
37-
POETRY_PYPI_TOKEN_PYPI: ${{ secrets.PYPI_API_TOKEN }}
40+
- name: Build package distribution
3841
run: |
39-
poetry config pypi-token.pypi ${{ secrets.PYPI_API_TOKEN }}
4042
poetry build
41-
poetry publish
43+
- name: Publish package distributions to PyPI
44+
uses: pypa/gh-action-pypi-publish@release/v1

0 commit comments

Comments
 (0)