From c6f7928c275dd7fdba537685f334c248e20be7d3 Mon Sep 17 00:00:00 2001 From: ftoromanoff Date: Tue, 1 Oct 2024 15:45:40 +0200 Subject: [PATCH] refactor(entwine): supp confing.crs --- examples/entwine_3d_loader.html | 1 - examples/entwine_simple_loader.html | 1 - src/Layer/EntwinePointTileLayer.js | 6 ------ 3 files changed, 8 deletions(-) diff --git a/examples/entwine_3d_loader.html b/examples/entwine_3d_loader.html index 9c6414e409..94864f1fa1 100644 --- a/examples/entwine_3d_loader.html +++ b/examples/entwine_3d_loader.html @@ -96,7 +96,6 @@ eptLayer = new itowns.EntwinePointTileLayer('Entwine Point Tile', { source: eptSource, - crs: view.referenceCrs, }); itowns.View.prototype.addLayer.call(view, eptLayer).then(onLayerReady); diff --git a/examples/entwine_simple_loader.html b/examples/entwine_simple_loader.html index ae2afd7945..ab2314c5ba 100644 --- a/examples/entwine_simple_loader.html +++ b/examples/entwine_simple_loader.html @@ -95,7 +95,6 @@ const config = { source: eptSource, - crs: view.referenceCrs, ...options, } eptLayer = new itowns.EntwinePointTileLayer('Entwine Point Tile', config); diff --git a/src/Layer/EntwinePointTileLayer.js b/src/Layer/EntwinePointTileLayer.js index bb214a33ab..b380d29d5d 100644 --- a/src/Layer/EntwinePointTileLayer.js +++ b/src/Layer/EntwinePointTileLayer.js @@ -34,9 +34,6 @@ class EntwinePointTileLayer extends PointCloudLayer { * contains three elements `name, protocol, extent`, these elements will be * available using `layer.name` or something else depending on the property * name. See the list of properties to know which one can be specified. - * @param {string} [config.crs=ESPG:4326] - The CRS of the {@link View} this - * layer will be attached to. This is used to determine the extent of this - * layer. Default to `EPSG:4326`. * @param {number} [config.skip=1] - Read one point from every `skip` points * - see {@link LASParser}. */ @@ -44,11 +41,8 @@ class EntwinePointTileLayer extends PointCloudLayer { super(id, config); this.isEntwinePointTileLayer = true; this.scale = new THREE.Vector3(1, 1, 1); - const resolve = this.addInitializationStep(); this.whenReady = this.source.whenReady.then(() => { - if (this.crs !== config.crs) { console.warn('layer.crs is different from View.crs'); } - // NOTE: this spacing is kinda arbitrary here, we take the width and // length (height can be ignored), and we divide by the specified // span in ept.json. This needs improvements.