Camera component tooltip

[laurynas111]

Hi,

I've noticed that viewtogglecameratool (https://www.itwinjs.org/reference/core-frontend/tools/viewtogglecameratool/) tooltip is not very informative. It just says "Turn Camera On/Off". Wouldn't it be better to rename to something more informative? e.g. "Orthogonal/Perspective View"

Thanks,
Laurynas

[GerardasB]

Alternative labels are correct - the tool does toggle between orthogonal and perspective projections:
https://github.com/iTwin/itwinjs-core/blob/59c7ef435b7fca9e095d0d4fab90551d93ebbfc1/core/frontend/src/ViewState.ts#L1805
https://github.com/iTwin/itwinjs-core/blob/59c7ef435b7fca9e095d0d4fab90551d93ebbfc1/core/frontend/src/ViewState.ts#L147

However, that wording is rarely used in our docs and is usually referred to "camera on/off", which aligns with the tool icon as well: https://www.itwinjs.org/reference/core-frontend/tools/viewtogglecameratool/
https://www.itwinjs.org/reference/core-frontend/views/viewport/turncameraon/

@FlyersPh9, @markschlosseratbentley thoughts on labelling/docs?

[markschlosseratbentley]

It has historically been this for a while. I personally think the most important aspect is consistency in how it is described.

Tagging @bbastings @pmconne for any other thoughts.

[bbastings]

I don't like naming things. Camera On/Off is not super accurate certainly, but I always assumed that was more understandable for folks. Is using Orthogonal for a Parallel Projection better than Perspective On/Off? I don't know...

I personally think the most important aspect is consistency in how it is described.
@markschlosseratbentley 100% agree with this. :)