-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Circles with large sweep angle do not render not as expected #7748
Comments
Pretty, but we'll fix this. Thanks for pointing it out! |
I was not able to regenerate this using However, if I call We think the display code may be calling into core-geometry to stroke the arc, which is how it gets to I am working to fix the issue by limiting the angle sweep in |
Should use AngleSweep.create(Angle.createDegrees(...)) to reproduce the problem. The sandbox linked above uses AngleSweep.createStartEndDegrees(...), whose implementation already limits the resulting AngleSweep to 360 degrees if it exceeds that value. |
Right. I modified the sandbox and now I can regenerate the issue. We resolved the issue here by limiting the sweep to 360 degrees in Arc3d constructor. It should be available in the next iTwin version but will take some time to be available in the sandbox as they get updated less frequently. |
Describe the bug
When I create a circle with a large sweep angle (e.g., 7200 degrees), the circle does not render as expected (as shown in the following image). Maybe we could add restrictions to the Arc3d API to prevent the user from creating such circles or fix the rendering issue. (As far as I know, in MicroStation, we can create such circles and they render correctly.)
To Reproduce
We can use the following code to generate the problematic circle:
Arc3d.create(Point3d.create(0, 0, 0), Vector3d.unitX(), Vector3d.unitY(), AngleSweep.create(Angle.createDegrees(7200)))
The text was updated successfully, but these errors were encountered: