Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hierarchies-react]: Add ability to disable filter button render on hover #815

Closed
saskliutas opened this issue Dec 18, 2024 · 6 comments · Fixed by #840
Closed

[hierarchies-react]: Add ability to disable filter button render on hover #815

saskliutas opened this issue Dec 18, 2024 · 6 comments · Fixed by #840
Assignees
Labels
enhancement New feature or request presentation

Comments

@saskliutas
Copy link
Member

There might be use cases where hierarchy level limit is reached rarely and in those cases showing filter button on hover might by undesirable. For those cases we should add a simple way to disable filter button render on hover.

It would still be possible to apply filter through info node if hierarchy level limit is exceeded. If filter is applied Clear and Filter should be rendered regardless.

@saskliutas saskliutas added enhancement New feature or request presentation labels Dec 18, 2024
@MartynasStrazdas MartynasStrazdas self-assigned this Jan 15, 2025
@MartynasStrazdas
Copy link
Contributor

Perhaps we could allow user to choose to disable button-based filtering, leave it on hover or allow display of all filter buttons?

@grigasp
Copy link
Member

grigasp commented Jan 15, 2025

Perhaps we could allow user to choose to disable button-based filtering, leave it on hover or allow display of all filter buttons?

By "user" you mean "consumer", right?

Also, just to confirm, are you suggesting that we provide 3 options: "no filtering buttons", "show filtering buttons on hover", "always show filtering buttons"?

@MartynasStrazdas
Copy link
Contributor

Perhaps we could allow user to choose to disable button-based filtering, leave it on hover or allow display of all filter buttons?

By "user" you mean "consumer", right?

Also, just to confirm, are you suggesting that we provide 3 options: "no filtering buttons", "show filtering buttons on hover", "always show filtering buttons"?

Yes and yes.

@grigasp
Copy link
Member

grigasp commented Jan 15, 2025

Perhaps we could allow user to choose to disable button-based filtering, leave it on hover or allow display of all filter buttons?

By "user" you mean "consumer", right?
Also, just to confirm, are you suggesting that we provide 3 options: "no filtering buttons", "show filtering buttons on hover", "always show filtering buttons"?

Yes and yes.

I can't think of a reason anyone would want to see those buttons all the time. But I guess to future-proof ourselves we could use a string union prop rather than a boolean for this. Initially that could be "hide" | "show-on-hover", and if there's a need, we could add | "show-always" in the future. What do you think?

@saskliutas
Copy link
Member Author

Perhaps we could allow user to choose to disable button-based filtering, leave it on hover or allow display of all filter buttons?

By "user" you mean "consumer", right?
Also, just to confirm, are you suggesting that we provide 3 options: "no filtering buttons", "show filtering buttons on hover", "always show filtering buttons"?

Yes and yes.

I can't think of a reason anyone would want to see those buttons all the time. But I guess to future-proof ourselves we could use a string union prop rather than a boolean for this. Initially that could be "hide" | "show-on-hover", and if there's a need, we could add | "show-always" in the future. What do you think?

I guess in touch devices you could want to show button always.

@grigasp
Copy link
Member

grigasp commented Jan 15, 2025

I guess in touch devices you could want to show button always.

Maybe... Let's not overthink this for now and instead wait for iTwinUI v5 and their recommendations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request presentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants