-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unified-selection-react
package
#841
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8765afe The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Unified selection benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
Hierarchies benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
JonasDov
reviewed
Jan 20, 2025
Co-authored-by: JonasDov <[email protected]>
saskliutas
requested changes
Jan 20, 2025
packages/components/src/presentation-components/common/UnifiedSelection.tsx
Outdated
Show resolved
Hide resolved
saskliutas
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #829
Closes #830
This probably should've been at least 2 PRs, but there was a lot of back and forth, and I didn't want to waste time splitting them afterwards.
The new package now provides a React context that other packages can use, so consumers don't need to have a separate provider for each package. However, I also made changes in
hierarchies-react
andcomponents
to consume selection storage through a prop rather than context, so the context is only used byInstanceKeyValueRenderer
, which has no way of getting the selection storage through prop.