Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unified-selection: Doc improvements #867

Merged
merged 5 commits into from
Feb 4, 2025

Conversation

grigasp
Copy link
Member

@grigasp grigasp commented Feb 4, 2025

Closes #859.

@grigasp grigasp requested a review from a team as a code owner February 4, 2025 12:41
Copy link

changeset-bot bot commented Feb 4, 2025

⚠️ No Changeset found

Latest commit: dae61bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

github-actions bot commented Feb 4, 2025

Unified selection benchmark

Benchmark suite Current: dae61bf Previous: 25b3754 Deviation Status
hilite 50k elements 1231.41 ms 1150.29 ms 7.0521% 🚨
hilite 50k elements (P95 of main thread blocks) 55 ms 48 ms 14.5833% 🚨
hilite 50k group elements 237.29 ms 233.06 ms 1.8150% 🚨
hilite 50k group elements (P95 of main thread blocks) 31 ms 31 ms 0% 🟰
hilite 1k subjects 46634.37 ms 45199.35 ms 3.1749% 🚨
hilite 1k subjects (P95 of main thread blocks) 32 ms 32 ms 0% 🟰
hilite 50k subcategories 276.55 ms 278.99 ms -0.8746%
hilite 50k subcategories (P95 of main thread blocks) 33 ms 33 ms 0% 🟰
hilite 50k functional 3D elements 27684.29 ms 27669.08 ms 0.0550% 🚨
hilite 50k functional 3D elements (P95 of main thread blocks) 43 ms 41 ms 4.8780% 🚨
hilite 50k functional 2D elements 6374.29 ms 6364.5 ms 0.1538% 🚨
hilite 50k functional 2D elements (P95 of main thread blocks) 31 ms 40 ms -22.5000%
compute selection for 50k elements 341.81 ms 308.35 ms 10.8513% 🚨
compute selection for 50k elements (P95 of main thread blocks) 36 ms 31 ms 16.1290% 🚨
compute parent selection for 50k elements 341.71 ms 352.41 ms -3.0362%
compute parent selection for 50k elements (P95 of main thread blocks) 33 ms 32 ms 3.1250% 🚨
compute top ancestor selection for 50k elements 576.5 ms 577.71 ms -0.2094%
compute top ancestor selection for 50k elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute category selection for 50k elements 90.54 ms 92.98 ms -2.6242%
compute category selection for 50k elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute model selection for 50k elements 72.87 ms 84.13 ms -13.3840%
compute model selection for 50k elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute functional selection for 50k 3D elements 401.78 ms 395.87 ms 1.4929% 🚨
compute functional selection for 50k 3D elements (P95 of main thread blocks) 31 ms 31 ms 0% 🟰
compute parent functional selection for 50k 3D elements 435.34 ms 470.47 ms -7.4670%
compute parent functional selection for 50k 3D elements (P95 of main thread blocks) 33 ms 34 ms -2.9412%
compute top ancestor functional selection for 50k 3D elements 1199.15 ms 1154.43 ms 3.8738% 🚨
compute top ancestor functional selection for 50k 3D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute functional selection for 50k 2D elements 3126.1 ms 2944.12 ms 6.1811% 🚨
compute functional selection for 50k 2D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute parent functional selection for 50k 2D elements 3129.1 ms 2916.01 ms 7.3076% 🚨
compute parent functional selection for 50k 2D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute top ancestor functional selection for 50k 2D elements 3201.41 ms 2984.17 ms 7.2797% 🚨
compute top ancestor functional selection for 50k 2D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

@grigasp grigasp enabled auto-merge (squash) February 4, 2025 13:02
@grigasp grigasp merged commit a17aa52 into master Feb 4, 2025
12 checks passed
@grigasp grigasp deleted the unified-selection/doc-improvements branch February 4, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants