Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading polyline edges #378

Closed
yun-vis opened this issue Aug 7, 2018 · 6 comments
Closed

Loading polyline edges #378

yun-vis opened this issue Aug 7, 2018 · 6 comments

Comments

@yun-vis
Copy link

yun-vis commented Aug 7, 2018

Hi,

I was reading a sbgn file using newt since it is a great tool to explore the data.
I have encountered a problem that the system could not load polyline edges appropriately. The start or end elements appear to be empty, which lead to missing edges.

After several testing, I found that Newt has a function when a user drags an anchor point of on an edge to a node, it will automatically merge the anchor to the node. However, if the anchors were merged in a bad order, the entire edge will disappear. Please refer to the following video for an example.

https://www.dropbox.com/s/h3a1890v9zqp3ai/output.mov?dl=0
(This test file can be found here.
https://www.dropbox.com/s/7srujc00z347dqs/new_file.sbgnml?dl=0)

Due to this functionality, I assume that the sbgn file I have created cannot be well displayed on Newt. Note that the edges are there. One can see them after clicking on the force-directed layout.

One of my sample files is here.
https://www.dropbox.com/s/ayuol2yyba0ub4v/example.sbgnml?dl=0

To solve this issue should I confirm that all anchors of my polylines are outside the nodes? or is there any better way to solve this problem?

Thank you very much for your support.

Best regards,
Yun

@ugurdogrusoz
Copy link
Contributor

@maxkfranz is this a Cytoscape.js bug or are we doing something wrong in our app? Our Cytoscape.js fork should be based on Cytoscape.js 3.1.1.

@maxkfranz
Copy link

I don't know off hand. You'd have to go through all the milestones between 3.1.1 and the current version to be sure. This underscores the case for using an up-to-date, non-forked version of Cytoscape.js. SBGN can be rendered just by specifying the stylesheet appropriately, e.g. with the cytoscape-sbgn-stylesheet module.

The only case where an edge should not be drawn is if the edge has an invalid specification --- i.e. the edge is impossible to draw as specified.

@hasanbalci
Copy link
Contributor

The edge is not drawn for the same case in the edge-bend-editing extension demo that uses the latest version of the Cytoscape.js. It seems that the problem only occurs when source-endpoint & target-endpoint of the edge are set to "outside-to-node". Edge is drawn when these attributes are set to other options.

@maxkfranz
Copy link

You may need to restrict the points to enforce that an intersection is possible for outside-to-node.

@yun-vis
Copy link
Author

yun-vis commented Aug 27, 2018

I agree. This seems to be a problem from Cytoscape.js. Thank you very much for pointing it out and I will do some workaround with it.

@hasanbalci
Copy link
Contributor

I move the issue to iVis-at-Bilkent/cytoscape.js-edge-editing#21, since it's more related with the extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants