Why prefer HTMLElement?

[saschanaz]

I found that the code prefers HTMLElement to Element:

smoothscroll/src/smoothscroll.js

Line 18 in 8a19e81

var Element = w.HTMLElement || w.Element;

...and causes adding scrollIntoView() to HTMLElement instead of Element. What was the reasoning there?

[iamdustan]

🤷‍♂️ do you have an argument or reasoning to change it that is currently broken?

[saschanaz]

Recalling what was the problem... Ah, it caused feature detection to falsely fail, as the code expected Element.prototype.scrollIntoView to exist.

[elliottregan]

That's a good point. MDN has .scrollIntoView() listed under Element, which is backed up by the CSSOM View Module spec.

Looks like it should prefer Element over HTMLElement. I haven't tested this with other implementations of Element, like SVGElement, but it sounds like it should work in browsers that support the extension, and so this polyfill should allow that, as well.

[acontreras89]

Possibly related to #153