-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why does Listing#variations require secure? #122
Comments
@kaoru I'm not sure. For a while listing variations were coming back empty, and I seem to recall that adding oauth to the call caused the variations to come back, but it's been a while and I don't recall the details. If it now works without it I'd gladly accept a change that removes the secure requirement. |
@kytrinyx cool, I'll see if I can write up a pull request for you 👍 Sadly my Etsy app is "waiting for approval" so until the folks over at Etsy can approve it this is probably going to wallow near the bottom of my priority list 😄 |
@kaoru Totally understand. Since I no longer have any Etsy apps, this tends to wallow at the bottom of mine as well ❤️ |
https://github.com/kytrinyx/etsy/blob/master/lib/etsy/listing.rb#L145
Is there any reason for this to have the
require_secure
parameter set? It seems to work without it.Thanks.
The text was updated successfully, but these errors were encountered: