Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript typings dont work with bundler moduleResolution #169

Open
steelbrain opened this issue Oct 1, 2024 · 0 comments · May be fixed by #170
Open

Typescript typings dont work with bundler moduleResolution #169

steelbrain opened this issue Oct 1, 2024 · 0 comments · May be fixed by #170

Comments

@steelbrain
Copy link

Hello!

Thanks for making this package! It seems that typings are broken when tsconfig sets module resolution to bundler. Here's a repository with a reproduction: https://github.com/steelbrain/bug-reproduction-2024-10-use-font-face-observer

Here's the error message

There are types at 'bug-reproduction-2024-10-use-font-face-observer/node_modules/use-font-face-observer/dist/index.d.ts', but this result could not be resolved when respecting package.json "exports". The 'use-font-face-observer' library may need to update its package.json or typings.
steelbrain added a commit to steelbrain/use-font-face-observer that referenced this issue Oct 1, 2024
@steelbrain
Specify types path in package.json#exports
7bba517 
This fixes Typescript support with moduleResolution set to bundler

Fixes iamskok#169
@steelbrain steelbrain linked a pull request Oct 1, 2024 that will close this issue
Open
@steelbrain steelbrain changed the title Typescript typings dont work in some situations with Typescript Typescript typings dont work with bundler moduleResolution Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Specify types path in package.json#exports steelbrain/use-font-face-observer
1 participant
@steelbrain