Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy linting in Travis ci #21

Open
iankronquist opened this issue Jan 28, 2017 · 1 comment
Open

Fix clippy linting in Travis ci #21

iankronquist opened this issue Jan 28, 2017 · 1 comment

Comments

@iankronquist
Copy link
Owner

It's both disabled and broken.

$ cargo clippy -- -D clippy || true

/home/travis/.cargo/bin/cargo-clippy: symbol lookup error: /home/travis/.cargo/bin/cargo-clippy: undefined symbol: _ZN53_$LT$rustc..hir..UnOp$u20$as$u20$core..fmt..Debug$GT$3fmt17h6ffc22e1063b0efaE
@iankronquist
Copy link
Owner Author

iankronquist commented Oct 12, 2017

  • Update pinned nightly rust compiler version to latest working date in travis ci.
  • Pin clippy to a compatible (probably latest) version in travis ci.
  • Fix clippy lints (should be an exercise in fancy search 'n replace).
  • Make clippy a requirement to merge a PR (remove || true).
  • (optional, easy, recommended) Speed up CI runs by caching the results of the ~/.cargo directory since clippy takes forever to compile. https://docs.travis-ci.com/user/caching/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant