Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ⌘+P file search #6

Open
andrewckor opened this issue Sep 5, 2018 · 4 comments
Open

Add support for ⌘+P file search #6

andrewckor opened this issue Sep 5, 2018 · 4 comments

Comments

@andrewckor
Copy link

I love how it works so far, great job!
It would be super handy to add support for filename searching through:

{   "key": "cmd+p",   "command": "workbench.action.quickOpenNavigateNextInFilePicker",   "when": "inFilesPicker && inQuickOpen" }

I haven't see the code and I don't know how your extension works, but I assuming that if the completely file list is available in the FilesPicker then would be easier to open a file without click through every file.

@andrewckor
Copy link
Author

I would also love to be involved in the development process of this extension if I can help in any way.

@iann0036
Copy link
Owner

iann0036 commented Sep 5, 2018

Hi Andrew,

I can certainly look into adding filename search support. It'll possibly only be partially available at first as it may require me to walk the remote filesystem.

As for contributions, feel free to raise pull requests if you're technically inclined, however what I'm really after right now is bug reports. Any issues (or feature requests) you have, please raise an issue for them.

@iann0036
Copy link
Owner

iann0036 commented Sep 8, 2018

It does look like custom file search providers are coming but is not in the main release as of yet. I will start working on this when I have time, however this could be 2-3 months away from being able to release regardless of my progress.

@leighs-hammer
Copy link

+1 on this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants